[Bf-codereview] 2.5x blenderplayer (BGE) anti-aliasing & embedding (issue4431072)

[dfelinto at gmail.com]

patch commited to trunk with some final small adjustments.
review #36470

(is there any option to close this issue?)


http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp
File intern/ghost/intern/GHOST_WindowWin32.cpp (right):

http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp#newcode714
intern/ghost/intern/GHOST_WindowWin32.cpp:714: while (iAttributes[17] >
0) {
On 2011/04/28 21:53:25, jesterKing wrote:
> iAttributes[17] looks very obscure. At least have a comment explaining
it, or
> better yet, a comment *and* a descriptive #define for 17
It's not that obscure. iAttributes is defined above and [17] stands for
multisampling. I think a #define would be a bit overkill so I added only
a comment :)

http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp#newcode721
intern/ghost/intern/GHOST_WindowWin32.cpp:721: #ifdef BF_GHOST_DEBUG
I created GHOST_PRINTF (couldn't test though, I forgot how to enable
ghost debugging).

http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp#newcode727
intern/ghost/intern/GHOST_WindowWin32.cpp:727: iAttributes[17] -= 1;
On 2011/04/28 21:53:25, jesterKing wrote:
> See the previous comment about iAttributes[17]
See the previous reply ;)

http://codereview.appspot.com/4431072/diff/1/intern/ghost/intern/GHOST_WindowWin32.cpp#newcode735
intern/ghost/intern/GHOST_WindowWin32.cpp:735: #endif // BF_GHOST_DEBUG
done

http://codereview.appspot.com/4431072/diff/1/source/gameengine/GamePlayer/ghost/GPG_Application.h
File source/gameengine/GamePlayer/ghost/GPG_Application.h (right):

http://codereview.appspot.com/4431072/diff/1/source/gameengine/GamePlayer/ghost/GPG_Application.h#newcode66
source/gameengine/GamePlayer/ghost/GPG_Application.h:66: const bool
stereoVisual, const int stereoMode, const GHOST_TUns16 samples=0);
sorry Nathan, next time? I'm still a bit clueless regarding Doxygen. I
do want to help it to be in bge code but I will do it at once. To get
this patch in trunk we must...

On 2011/04/28 21:53:25, jesterKing wrote:
> I know there hasn't been much before here, but please, add doxygen
style docs in
> headers whenever you add something :)

http://codereview.appspot.com/4431072/