[Bf-codereview] Use DerivedMesh instead of Mesh in COLLADA GeometryExporter (issue4387052)

[brechtvanlommel at gmail.com]

This patch is not using DerivedMesh correctly, don't know how it can
even work, at least uv and vertex color export would probably crash.


http://codereview.appspot.com/4387052/diff/1/blender/source/blender/collada/GeometryExporter.cpp
File blender/source/blender/collada/GeometryExporter.cpp (right):

http://codereview.appspot.com/4387052/diff/1/blender/source/blender/collada/GeometryExporter.cpp#newcode73
blender/source/blender/collada/GeometryExporter.cpp:73: DerivedMesh *dm
= mesh_create_derived_view(mScene, ob, CD_MASK_BAREMESH);
Mask should include the layers you will use, i.e. CD_MASK_MTFACE,
CD_MASK_MCOL. Also, the derivedmesh is not being released at the end.

http://codereview.appspot.com/4387052/diff/1/blender/source/blender/collada/GeometryExporter.cpp#newcode89
blender/source/blender/collada/GeometryExporter.cpp:89: CustomData
*face_data = static_cast<CustomData *>(dm->getFaceDataArray(dm,
CD_MTFACE));
This can't work, dm->getFaceDataArray does not return CustomData*, it
returns the actual layer data if it exists. dm->faceData has it.

http://codereview.appspot.com/4387052/