[Bf-codereview] Blender Animation: Jog keys (issue4298043)

[brechtvanlommel at gmail.com]

Thanks for using the system, nice to see it getting used, some comments
below.


http://codereview.appspot.com/4298043/diff/1/source/blender/editors/screen/screen_ops.c
File source/blender/editors/screen/screen_ops.c (right):

http://codereview.appspot.com/4298043/diff/1/source/blender/editors/screen/screen_ops.c#newcode2758
source/blender/editors/screen/screen_ops.c:2758: if((scene->audio.flag &
AUDIO_SYNC) && !(sad->flag & ANIMPLAY_FLAG_REVERSE) && finite(time =
sound_sync_scene(scene)))
This doesn't seem consistent with ED_screen_animation_play, there
playing sound is disabled if speed != 1, probably should do that here
too.

http://codereview.appspot.com/4298043/diff/1/source/blender/editors/screen/screen_ops.c#newcode2895
source/blender/editors/screen/screen_ops.c:2895: speed_mul =
(sad->speed_mul < ANIMPLAYER_MAX_SPEEDMUL) ? sad->speed_mul+1 :
ANIMPLAYER_MAX_SPEEDMUL;
I was expecting each key press to double speed, and then have the max 16
or so. That's mostly based on what I'm used to in video players though.

Actually why not make speed_mul a float, and make it possible to halve
the playback speed too using these keys?

http://codereview.appspot.com/4298043/diff/1/source/blender/editors/screen/screen_ops.c#newcode2944
source/blender/editors/screen/screen_ops.c:2944:
RNA_def_boolean(ot->srna, "toggle", 1, "Toggle", "Toggle
forward/backward rather than stopping the animation");
This description is not clear to me. Maybe flip the boolean and call it
adjust_speed?

http://codereview.appspot.com/4298043/