[Bf-codereview] modeler normals don't match render normals (issue4280049)

[Morten Mikkelsen]

Now that my code has mostly been taken out I think I will leave it to
someone else to clean up some day in
the vertex normal calculation functions. But I can apply the changes you're
talking about to convertblender.c

In regards to getRealVertNo I think dropping it is a bad idea since it's
going to be needed for
the exporters soon but if you don't want it unless it's also implemented on
the other mesh types
I'll let it go. I can leave it to jesterking to put it in again when he's
ready.




On Tue, Mar 15, 2011 at 11:39 AM, <brechtvanlommel at gmail.com> wrote:

>
>
> http://codereview.appspot.com/4280049/diff/8003/source/blender/blenkernel/intern/cdderivedmesh.c
> File source/blender/blenkernel/intern/cdderivedmesh.c (right):
>
>
> http://codereview.appspot.com/4280049/diff/8003/source/blender/blenkernel/intern/cdderivedmesh.c#newcode1869
> source/blender/blenkernel/intern/cdderivedmesh.c:1869: /* calculate face
> normals and add to vertex normals */
> Also, it seems the last parameter in mesh_calc_normals is unused, so it
> can be changed to not allocate the face normals but fill them in in the
> existing array and avoid memcpy.
>
>
> http://codereview.appspot.com/4280049/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-codereview/attachments/20110315/a2cc0d7c/attachment.htm