<div>Now that my code has mostly been taken out I think I will leave it to someone else to clean up some day in</div><div>the vertex normal calculation functions. But I can apply the changes you're talking about to convertblender.c</div>
<div><br></div><div>In regards to <span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">getRealVertNo I think dropping it is a bad idea since it's going to be needed for</span></div>
<div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">the exporters soon but if you don't want it unless it's also implemented on the other mesh types</span></div>
<div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; ">I'll let it go. I can leave it to jesterking to put it in again when he's ready.</span></div>
<div><span class="Apple-style-span" style="border-collapse: collapse; font-family: arial, sans-serif; font-size: 13px; "><br></span></div><div><br></div><br><br><div class="gmail_quote">On Tue, Mar 15, 2011 at 11:39 AM, <span dir="ltr"><<a href="mailto:brechtvanlommel@gmail.com">brechtvanlommel@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im"><br>
<a href="http://codereview.appspot.com/4280049/diff/8003/source/blender/blenkernel/intern/cdderivedmesh.c" target="_blank">http://codereview.appspot.com/4280049/diff/8003/source/blender/blenkernel/intern/cdderivedmesh.c</a><br>
File source/blender/blenkernel/intern/cdderivedmesh.c (right):<br>
<br>
<a href="http://codereview.appspot.com/4280049/diff/8003/source/blender/blenkernel/intern/cdderivedmesh.c#newcode1869" target="_blank">http://codereview.appspot.com/4280049/diff/8003/source/blender/blenkernel/intern/cdderivedmesh.c#newcode1869</a><br>
source/blender/blenkernel/intern/cdderivedmesh.c:1869: /* calculate face<br>
normals and add to vertex normals */<br></div>
Also, it seems the last parameter in mesh_calc_normals is unused, so it<br>
can be changed to not allocate the face normals but fill them in in the<br>
existing array and avoid memcpy.<div><div></div><div class="h5"><br>
<br>
<a href="http://codereview.appspot.com/4280049/" target="_blank">http://codereview.appspot.com/4280049/</a><br>
</div></div></blockquote></div><br>