[Bf-codereview] modeler normals don't match render normals (issue4280049)

[Morten Mikkelsen]

But it has to iterate over the faces twice.

Removing the iteration from the abstraction would conflict with that.


On Tue, Mar 15, 2011 at 7:36 AM, <brechtvanlommel at gmail.com> wrote:

> On 2011/03/15 14:32:13, brechtvl wrote:
>
>> On 2011/03/15 14:28:55, mikkelsen7 wrote:
>> > So you'd be happy with it the way it is if I took out the mem-clear
>>
> and the
>
>> > normalization
>> > thus getting rid of the ability to iterate over the vertices?
>>
>
>  I'd like to see all iterators removed. I don't see the need to share
>>
> anything
>
>> more than a single function with a dozen lines of code.
>>
>
> I forgot, a function like accumulate_vertex_normals would also have a
> parameter to indicate if the face is smooth or not, to share that
> behavior too. You can also add functions to clear and normalize the
> vertex normal, to encapsulate that better too.
>
>
> http://codereview.appspot.com/4280049/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-codereview/attachments/20110315/a31a0290/attachment-0001.htm