But it has to iterate over the faces twice.<div><br></div><div>Removing the iteration from the abstraction would conflict with that.</div><div><br><br><div class="gmail_quote">On Tue, Mar 15, 2011 at 7:36 AM, <span dir="ltr"><<a href="mailto:brechtvanlommel@gmail.com">brechtvanlommel@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="im">On 2011/03/15 14:32:13, brechtvl wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 2011/03/15 14:28:55, mikkelsen7 wrote:<br>
> So you'd be happy with it the way it is if I took out the mem-clear<br>
</blockquote>
and the<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> normalization<br>
> thus getting rid of the ability to iterate over the vertices?<br>
</blockquote>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'd like to see all iterators removed. I don't see the need to share<br>
</blockquote>
anything<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
more than a single function with a dozen lines of code.<br>
</blockquote>
<br></div>
I forgot, a function like accumulate_vertex_normals would also have a<br>
parameter to indicate if the face is smooth or not, to share that<br>
behavior too. You can also add functions to clear and normalize the<br>
vertex normal, to encapsulate that better too.<div><div></div><div class="h5"><br>
<br>
<a href="http://codereview.appspot.com/4280049/" target="_blank">http://codereview.appspot.com/4280049/</a><br>
</div></div></blockquote></div><br></div>