[Bf-codereview] BGE: Material replacement for texface options (issue4289041)

[brechtvanlommel at gmail.com]

Some more naming nits.

Overall: could we use a single name for "alpha mode", "blend mode",
"alpha blend" and "transp" throughout the code, RNA api and UI?


http://codereview.appspot.com/4289041/diff/11002/source/blender/makesdna/DNA_material_types.h
File source/blender/makesdna/DNA_material_types.h (right):

http://codereview.appspot.com/4289041/diff/11002/source/blender/makesdna/DNA_material_types.h#newcode81
source/blender/makesdna/DNA_material_types.h:81: int face_ori;
Just name it int face_orientation;, not need for abbrevation.

http://codereview.appspot.com/4289041/diff/11002/source/blender/makesdna/DNA_material_types.h#newcode101
source/blender/makesdna/DNA_material_types.h:101: struct GameSettings
gameopt;
Can this just be named "game", opt postfix is not common in blender.

http://codereview.appspot.com/4289041/diff/11002/source/blender/makesrna/intern/rna_material.c
File source/blender/makesrna/intern/rna_material.c (right):

http://codereview.appspot.com/4289041/diff/11002/source/blender/makesrna/intern/rna_material.c#newcode721
source/blender/makesrna/intern/rna_material.c:721: {GEMAT_ALPHA_SORT,
"ALPHASORT", 0, "Alpha Sort", "Sort faces for correct alpha drawing
(slow, use Alpha Clip instead when possible)"},
Change "ALPHASORT" to "ALPHA_SORT".

http://codereview.appspot.com/4289041/diff/11002/source/gameengine/Converter/BL_BlenderDataConversion.cpp
File source/gameengine/Converter/BL_BlenderDataConversion.cpp (right):

http://codereview.appspot.com/4289041/diff/11002/source/gameengine/Converter/BL_BlenderDataConversion.cpp#newcode234
source/gameengine/Converter/BL_BlenderDataConversion.cpp:234: static
void SetDefaultFaceType(Scene* scene)
Change to SetDefaultLightMode.

http://codereview.appspot.com/4289041/diff/11002/source/gameengine/Rasterizer/RAS_IPolygonMaterial.h
File source/gameengine/Rasterizer/RAS_IPolygonMaterial.h (right):

http://codereview.appspot.com/4289041/diff/11002/source/gameengine/Rasterizer/RAS_IPolygonMaterial.h#newcode52
source/gameengine/Rasterizer/RAS_IPolygonMaterial.h:52: struct
GameOptions;
Change to GameSettings.

http://codereview.appspot.com/4289041/