[Bf-codereview] BGE: Material replacement for texface options (issue4289041)

[nathan.letwory at gmail.com]

Some small comments, nothing big.


http://codereview.appspot.com/4289041/diff/1/source/gameengine/Converter/BL_BlenderDataConversion.cpp
File source/gameengine/Converter/BL_BlenderDataConversion.cpp (right):

http://codereview.appspot.com/4289041/diff/1/source/gameengine/Converter/BL_BlenderDataConversion.cpp#newcode93
source/gameengine/Converter/BL_BlenderDataConversion.cpp:93: #include
"BKE_image.h"
On 2011/03/11 19:58:26, dfelinto wrote:
> I have no idea when to include "includes" here or in the extern "C"
below.

Depends, some of the headers have an extern "C" block themselves, so you
can check those before deciding. If they have one, put them here. Best
would be to have the extern "C" blocks in each header themselves, so you
don't have to think about it later.

http://codereview.appspot.com/4289041/diff/1/source/gameengine/Converter/BL_BlenderDataConversion.cpp#newcode149
source/gameengine/Converter/BL_BlenderDataConversion.cpp:149: //#include
"IMB_imbuf.h"
I'd say just remove these lines altogether instead of commenting them
out.

http://codereview.appspot.com/4289041/diff/1/source/gameengine/Converter/BL_BlenderDataConversion.cpp#newcode625
source/gameengine/Converter/BL_BlenderDataConversion.cpp:625: /** No
material, what to do? let's see what is in the UV and set the material
accordingly
no need to put a /** doxygen starting comment here :)

http://codereview.appspot.com/4289041/diff/1/source/gameengine/Converter/BL_BlenderDataConversion.cpp#newcode1014
source/gameengine/Converter/BL_BlenderDataConversion.cpp:1014: /** set
render flags */
Again as earlier, no doxygen comment here

http://codereview.appspot.com/4289041/