[Bf-codereview] Google Breakpad + Crash Reporter (Win + Cmake) (issue4584052)

[elubie at gmx.net]

I have only been able to look at the blender integration which looks ok
to me apart from missing files ;)


http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/BP_main.h
File source/blender/breakpad/BP_main.h (right):

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/BP_main.h#newcode6
source/blender/breakpad/BP_main.h:6: extern int GBP_finish(void);
These have only implementations for Windows yet. I've seen that you are
still working on the Linux version, so I think it's ok at this stage.

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/CMakeLists.txt
File source/blender/breakpad/CMakeLists.txt (right):

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/CMakeLists.txt#newcode15
source/blender/breakpad/CMakeLists.txt:15: BP_apple.cpp
This file is missing from patch :)

http://codereview.appspot.com/4584052/diff/9001/source/blender/breakpad/CMakeLists.txt#newcode19
source/blender/breakpad/CMakeLists.txt:19: BP_linux.cpp
This file is missing from patch as well

http://codereview.appspot.com/4584052/