[Bf-codereview] Pepper to trunk merge (issue 4934047)

[ideasman42 at gmail.com]

follow up on some comments from nexyon.


http://codereview.appspot.com/4934047/diff/6043/release/scripts/startup/bl_ui/properties_data_speaker.py
File release/scripts/startup/bl_ui/properties_data_speaker.py (right):

http://codereview.appspot.com/4934047/diff/6043/release/scripts/startup/bl_ui/properties_data_speaker.py#newcode32
release/scripts/startup/bl_ui/properties_data_speaker.py:32: return
context.speaker and (engine in cls.COMPAT_ENGINES)
yep, dont worry about fixing this in the branch.

http://codereview.appspot.com/4934047/diff/6043/source/blender/blenkernel/intern/sound.c
File source/blender/blenkernel/intern/sound.c (right):

http://codereview.appspot.com/4934047/diff/6043/source/blender/blenkernel/intern/sound.c#newcode663
source/blender/blenkernel/intern/sound.c:663: for(ob =
bmain->object.first; ob; ob = ob->id.next)
Scenes can show set scenes - a background set.

See SETLOOPER macro, but again, this can wait until after the merge.

http://codereview.appspot.com/4934047/diff/6043/source/blender/editors/sound/sound_ops.c
File source/blender/editors/sound/sound_ops.c (right):

http://codereview.appspot.com/4934047/diff/6043/source/blender/editors/sound/sound_ops.c#newcode649
source/blender/editors/sound/sound_ops.c:649: void
SOUND_OT_update_animation_flags(wmOperatorType *ot)
when inserting and removing keyframes on seq data?

- the sequencer really doesn't work well with the animation system :S,
but think it would be good to add a comment here about why this is
needed and why its not simple to do automatically.

http://codereview.appspot.com/4934047/