[Bf-codereview] Pepper to trunk merge (issue 4934047)
nexyon at gmail.com
nexyon at gmail.com
Mon Aug 29 19:56:50 CEST 2011
Reviewers: bf-codereview_blender.org, brechtvl, ideasman42, jesterKing,
Moguri, dfelinto, theeth, aligorith,
Message:
Note: Merge is already scheduled for tomorrow between 8-10 am UTC in
case there are no real merge/show stoppers with Joshua, Brecht and
Nathan ready to help in case there are any problems.
Minor things can be fixed in trunk too and shouldn't unnecessarily delay
merging.
http://codereview.appspot.com/4934047/diff/6043/intern/audaspace/FX/AUD_BaseIIRFilterReader.cpp
File intern/audaspace/FX/AUD_BaseIIRFilterReader.cpp (right):
http://codereview.appspot.com/4934047/diff/6043/intern/audaspace/FX/AUD_BaseIIRFilterReader.cpp#newcode36
intern/audaspace/FX/AUD_BaseIIRFilterReader.cpp:36: #define CC
m_specs.channels + m_channel
Why exactly? I have never heard about such a define influencing anything
else than the file it is defined in and this is a .cpp that never gets
included anywhere.
http://codereview.appspot.com/4934047/diff/6043/intern/audaspace/intern/AUD_3DMath.h
File intern/audaspace/intern/AUD_3DMath.h (right):
http://codereview.appspot.com/4934047/diff/6043/intern/audaspace/intern/AUD_3DMath.h#newcode160
intern/audaspace/intern/AUD_3DMath.h:160: inline AUD_Vector3
operator*(const float& op) const
References are generally used for operator overloading when objects are
used as pointers are faster than copying a full object. In this case
it's true that a float might be faster than a pointer and smaller on 64
bit machines, but this operator is inline, so it doesn't matter anyway,
the reference might even make it easier for the compiler to recognize it
can use the original float.
http://codereview.appspot.com/4934047/diff/6043/intern/audaspace/intern/AUD_Reference.h
File intern/audaspace/intern/AUD_Reference.h (right):
http://codereview.appspot.com/4934047/diff/6043/intern/audaspace/intern/AUD_Reference.h#newcode123
intern/audaspace/intern/AUD_Reference.h:123: m_original = 0;
The reason I use 0 in this file is that NULL is not defined and I don't
really like to include a standard header just to get NULL defined, but
if you really want to, just tell me which header I should include best
and I'll change it.
http://codereview.appspot.com/4934047/diff/6043/release/scripts/startup/bl_ui/properties_data_speaker.py
File release/scripts/startup/bl_ui/properties_data_speaker.py (right):
http://codereview.appspot.com/4934047/diff/6043/release/scripts/startup/bl_ui/properties_data_speaker.py#newcode32
release/scripts/startup/bl_ui/properties_data_speaker.py:32: return
context.speaker and (engine in cls.COMPAT_ENGINES)
I guess this is something general regarding the blender python UI
source, Campbell might be interested, but it's not really relevant for
this specific review, is it?
http://codereview.appspot.com/4934047/diff/6043/source/blender/blenkernel/intern/sound.c
File source/blender/blenkernel/intern/sound.c (right):
http://codereview.appspot.com/4934047/diff/6043/source/blender/blenkernel/intern/sound.c#newcode663
source/blender/blenkernel/intern/sound.c:663: for(ob =
bmain->object.first; ob; ob = ob->id.next)
On 2011/08/23 18:39:45, ideasman42 wrote:
> This looks wrong, its playing all objects sounds in the blend file,
not just
> ones in the scene.
Fixed this by iterating over scene's bases now.
> Would be nice to loop over objects in `set` scenes too.
Don't understand what you mean here.
http://codereview.appspot.com/4934047/diff/6043/source/blender/editors/sound/sound_ops.c
File source/blender/editors/sound/sound_ops.c (right):
http://codereview.appspot.com/4934047/diff/6043/source/blender/editors/sound/sound_ops.c#newcode649
source/blender/editors/sound/sound_ops.c:649: void
SOUND_OT_update_animation_flags(wmOperatorType *ot)
The problem is: Where to do this in blender? Doing it every frame change
for example is quite a waste of time and according to joshua
id_data_find_fcurve isn't too fast.
http://codereview.appspot.com/4934047/diff/6043/source/blender/makesdna/DNA_speaker_types.h
File source/blender/makesdna/DNA_speaker_types.h (right):
http://codereview.appspot.com/4934047/diff/6043/source/blender/makesdna/DNA_speaker_types.h#newcode42
source/blender/makesdna/DNA_speaker_types.h:42: short flag;
Hmm, I thought it would be better to keep flag near the "head" of the
struct for the reason it's there in most other of blender's structs. But
can change it for sure, if you disagree.
Please review this at http://codereview.appspot.com/4934047/
Affected files:
M doc/python_api/rst/bge.types.rst
M intern/audaspace/CMakeLists.txt
M intern/audaspace/FX/AUD_AccumulatorFactory.cpp
M intern/audaspace/FX/AUD_AccumulatorFactory.h
M intern/audaspace/FX/AUD_BaseIIRFilterReader.cpp
M intern/audaspace/FX/AUD_BaseIIRFilterReader.h
M intern/audaspace/FX/AUD_ButterworthFactory.cpp
M intern/audaspace/FX/AUD_ButterworthFactory.h
M intern/audaspace/FX/AUD_CallbackIIRFilterReader.cpp
M intern/audaspace/FX/AUD_CallbackIIRFilterReader.h
M intern/audaspace/FX/AUD_DelayFactory.cpp
M intern/audaspace/FX/AUD_DelayFactory.h
M intern/audaspace/FX/AUD_DelayReader.cpp
M intern/audaspace/FX/AUD_DelayReader.h
M intern/audaspace/FX/AUD_DoubleFactory.cpp
M intern/audaspace/FX/AUD_DoubleFactory.h
M intern/audaspace/FX/AUD_DoubleReader.cpp
M intern/audaspace/FX/AUD_DoubleReader.h
A intern/audaspace/FX/AUD_DynamicIIRFilterFactory.cpp
A intern/audaspace/FX/AUD_DynamicIIRFilterFactory.h
A intern/audaspace/FX/AUD_DynamicIIRFilterReader.cpp
A intern/audaspace/FX/AUD_DynamicIIRFilterReader.h
M intern/audaspace/FX/AUD_EffectFactory.cpp
M intern/audaspace/FX/AUD_EffectFactory.h
M intern/audaspace/FX/AUD_EffectReader.cpp
M intern/audaspace/FX/AUD_EffectReader.h
M intern/audaspace/FX/AUD_EnvelopeFactory.cpp
M intern/audaspace/FX/AUD_EnvelopeFactory.h
M intern/audaspace/FX/AUD_FaderFactory.cpp
M intern/audaspace/FX/AUD_FaderFactory.h
M intern/audaspace/FX/AUD_FaderReader.cpp
M intern/audaspace/FX/AUD_FaderReader.h
M intern/audaspace/FX/AUD_HighpassFactory.cpp
M intern/audaspace/FX/AUD_HighpassFactory.h
M intern/audaspace/FX/AUD_IIRFilterFactory.cpp
M intern/audaspace/FX/AUD_IIRFilterFactory.h
M intern/audaspace/FX/AUD_IIRFilterReader.cpp
M intern/audaspace/FX/AUD_IIRFilterReader.h
M intern/audaspace/FX/AUD_LimiterFactory.cpp
M intern/audaspace/FX/AUD_LimiterFactory.h
M intern/audaspace/FX/AUD_LimiterReader.cpp
M intern/audaspace/FX/AUD_LimiterReader.h
M intern/audaspace/FX/AUD_LoopFactory.cpp
M intern/audaspace/FX/AUD_LoopFactory.h
M intern/audaspace/FX/AUD_LoopReader.cpp
M intern/audaspace/FX/AUD_LoopReader.h
M intern/audaspace/FX/AUD_LowpassFactory.cpp
M intern/audaspace/FX/AUD_LowpassFactory.h
M intern/audaspace/FX/AUD_PingPongFactory.cpp
M intern/audaspace/FX/AUD_PingPongFactory.h
M intern/audaspace/FX/AUD_PitchFactory.cpp
M intern/audaspace/FX/AUD_PitchFactory.h
M intern/audaspace/FX/AUD_PitchReader.cpp
M intern/audaspace/FX/AUD_PitchReader.h
M intern/audaspace/FX/AUD_RectifyFactory.cpp
M intern/audaspace/FX/AUD_RectifyFactory.h
M intern/audaspace/FX/AUD_ReverseFactory.cpp
M intern/audaspace/FX/AUD_ReverseFactory.h
M intern/audaspace/FX/AUD_ReverseReader.cpp
M intern/audaspace/FX/AUD_ReverseReader.h
M intern/audaspace/FX/AUD_SquareFactory.cpp
M intern/audaspace/FX/AUD_SquareFactory.h
M intern/audaspace/FX/AUD_SumFactory.cpp
M intern/audaspace/FX/AUD_SumFactory.h
M intern/audaspace/FX/AUD_SuperposeFactory.cpp
M intern/audaspace/FX/AUD_SuperposeFactory.h
M intern/audaspace/FX/AUD_SuperposeReader.cpp
M intern/audaspace/FX/AUD_SuperposeReader.h
M intern/audaspace/FX/AUD_VolumeFactory.cpp
M intern/audaspace/FX/AUD_VolumeFactory.h
M intern/audaspace/OpenAL/AUD_OpenALDevice.cpp
M intern/audaspace/OpenAL/AUD_OpenALDevice.h
M intern/audaspace/Python/AUD_PyAPI.cpp
M intern/audaspace/Python/AUD_PyAPI.h
M intern/audaspace/SRC/AUD_SRCResampleFactory.cpp
M intern/audaspace/SRC/AUD_SRCResampleFactory.h
M intern/audaspace/SRC/AUD_SRCResampleReader.cpp
M intern/audaspace/SRC/AUD_SRCResampleReader.h
M intern/audaspace/ffmpeg/AUD_FFMPEGFactory.cpp
M intern/audaspace/ffmpeg/AUD_FFMPEGFactory.h
M intern/audaspace/ffmpeg/AUD_FFMPEGReader.cpp
M intern/audaspace/ffmpeg/AUD_FFMPEGReader.h
A intern/audaspace/ffmpeg/AUD_FFMPEGWriter.cpp
A intern/audaspace/ffmpeg/AUD_FFMPEGWriter.h
M intern/audaspace/fftw/AUD_BandPassReader.cpp
M intern/audaspace/intern/AUD_3DMath.h
A intern/audaspace/intern/AUD_AnimateableProperty.cpp
A intern/audaspace/intern/AUD_AnimateableProperty.h
M intern/audaspace/intern/AUD_Buffer.cpp
M intern/audaspace/intern/AUD_Buffer.h
M intern/audaspace/intern/AUD_BufferReader.cpp
M intern/audaspace/intern/AUD_BufferReader.h
M intern/audaspace/intern/AUD_C-API.cpp
M intern/audaspace/intern/AUD_C-API.h
M intern/audaspace/intern/AUD_ChannelMapperFactory.cpp
M intern/audaspace/intern/AUD_ChannelMapperFactory.h
M intern/audaspace/intern/AUD_ChannelMapperReader.cpp
M intern/audaspace/intern/AUD_ChannelMapperReader.h
M intern/audaspace/intern/AUD_ConverterFactory.cpp
M intern/audaspace/intern/AUD_ConverterFactory.h
M intern/audaspace/intern/AUD_ConverterFunctions.cpp
M intern/audaspace/intern/AUD_ConverterReader.cpp
M intern/audaspace/intern/AUD_ConverterReader.h
M intern/audaspace/intern/AUD_FileFactory.cpp
M intern/audaspace/intern/AUD_FileFactory.h
A intern/audaspace/intern/AUD_FileWriter.cpp
A intern/audaspace/intern/AUD_FileWriter.h
M intern/audaspace/intern/AUD_I3DDevice.h
A intern/audaspace/intern/AUD_I3DHandle.h
M intern/audaspace/intern/AUD_IDevice.h
M intern/audaspace/intern/AUD_IFactory.h
A intern/audaspace/intern/AUD_IHandle.h
M intern/audaspace/intern/AUD_IReader.h
A intern/audaspace/intern/AUD_IWriter.h
A intern/audaspace/intern/AUD_JOSResampleFactory.cpp
A intern/audaspace/intern/AUD_JOSResampleFactory.h
A intern/audaspace/intern/AUD_JOSResampleReader.cpp
A intern/audaspace/intern/AUD_JOSResampleReader.h
M intern/audaspace/intern/AUD_LinearResampleFactory.cpp
M intern/audaspace/intern/AUD_LinearResampleFactory.h
M intern/audaspace/intern/AUD_LinearResampleReader.cpp
M intern/audaspace/intern/AUD_LinearResampleReader.h
M intern/audaspace/intern/AUD_Mixer.cpp
M intern/audaspace/intern/AUD_Mixer.h
M intern/audaspace/intern/AUD_MixerFactory.cpp
M intern/audaspace/intern/AUD_MixerFactory.h
M intern/audaspace/intern/AUD_NULLDevice.cpp
M intern/audaspace/intern/AUD_NULLDevice.h
M intern/audaspace/intern/AUD_ReadDevice.cpp
M intern/audaspace/intern/AUD_ReadDevice.h
M intern/audaspace/intern/AUD_Reference.h
A intern/audaspace/intern/AUD_ReferenceHandler.cpp
A intern/audaspace/intern/AUD_ResampleReader.cpp
A intern/audaspace/intern/AUD_ResampleReader.h
A intern/audaspace/intern/AUD_SequencerEntry.cpp
A intern/audaspace/intern/AUD_SequencerEntry.h
M intern/audaspace/intern/AUD_SequencerFactory.cpp
M intern/audaspace/intern/AUD_SequencerFactory.h
A intern/audaspace/intern/AUD_SequencerHandle.cpp
A intern/audaspace/intern/AUD_SequencerHandle.h
M intern/audaspace/intern/AUD_SequencerReader.cpp
M intern/audaspace/intern/AUD_SequencerReader.h
M intern/audaspace/intern/AUD_SilenceFactory.cpp
M intern/audaspace/intern/AUD_SilenceFactory.h
M intern/audaspace/intern/AUD_SilenceReader.cpp
M intern/audaspace/intern/AUD_SilenceReader.h
M intern/audaspace/intern/AUD_SinusFactory.cpp
M intern/audaspace/intern/AUD_SinusFactory.h
M intern/audaspace/intern/AUD_SinusReader.cpp
M intern/audaspace/intern/AUD_SinusReader.h
M intern/audaspace/intern/AUD_SoftwareDevice.cpp
M intern/audaspace/intern/AUD_SoftwareDevice.h
M intern/audaspace/intern/AUD_Space.h
M intern/audaspace/intern/AUD_StreamBufferFactory.cpp
M intern/audaspace/intern/AUD_StreamBufferFactory.h
M intern/audaspace/jack/AUD_JackDevice.cpp
M intern/audaspace/jack/AUD_JackDevice.h
M intern/audaspace/sndfile/AUD_SndFileFactory.cpp
M intern/audaspace/sndfile/AUD_SndFileFactory.h
M intern/audaspace/sndfile/AUD_SndFileReader.cpp
M intern/audaspace/sndfile/AUD_SndFileReader.h
A intern/audaspace/sndfile/AUD_SndFileWriter.cpp
A intern/audaspace/sndfile/AUD_SndFileWriter.h
M release/datafiles/blenderbuttons
M release/scripts/modules/bpy_types.py
A release/scripts/modules/mocap_constraints.py
A release/scripts/modules/mocap_tools.py
A release/scripts/modules/retarget.py
M release/scripts/presets/ffmpeg/DV.py
M release/scripts/presets/ffmpeg/DVD.py
M release/scripts/presets/ffmpeg/SVCD.py
M release/scripts/presets/ffmpeg/VCD.py
M release/scripts/startup/bl_operators/nla.py
M release/scripts/startup/bl_operators/object.py
M release/scripts/startup/bl_ui/__init__.py
M release/scripts/startup/bl_ui/properties_data_armature.py
A release/scripts/startup/bl_ui/properties_data_speaker.py
M release/scripts/startup/bl_ui/properties_game.py
M release/scripts/startup/bl_ui/properties_object_constraint.py
M release/scripts/startup/bl_ui/properties_render.py
M release/scripts/startup/bl_ui/properties_scene.py
M release/scripts/startup/bl_ui/space_dopesheet.py
M release/scripts/startup/bl_ui/space_graph.py
M release/scripts/startup/bl_ui/space_info.py
M release/scripts/startup/bl_ui/space_nla.py
M release/scripts/startup/bl_ui/space_sequencer.py
M release/scripts/startup/bl_ui/space_userpref.py
M release/scripts/startup/bl_ui/space_view3d.py
A release/scripts/startup/ui_mocap.py
M source/blender/CMakeLists.txt
M source/blender/blenfont/BLF_api.h
M source/blender/blenfont/intern/blf.c
M source/blender/blenkernel/BKE_action.h
M source/blender/blenkernel/BKE_anim.h
M source/blender/blenkernel/BKE_animsys.h
M source/blender/blenkernel/BKE_armature.h
M source/blender/blenkernel/BKE_constraint.h
M source/blender/blenkernel/BKE_fcurve.h
M source/blender/blenkernel/BKE_library.h
M source/blender/blenkernel/BKE_main.h
[[ 243 additional files ]]
More information about the Bf-codereview
mailing list