[Bf-blender-cvs] [bf352df27a6] blender-v3.2-release: Fix wrong USD image color space export with non-default OpenColorIO config
Brecht Van Lommel
noreply at git.blender.org
Fri May 20 17:09:12 CEST 2022
Commit: bf352df27a6f85d73bc0d6417f50fd62958cfb6e
Author: Brecht Van Lommel
Date: Fri May 20 16:41:51 2022 +0200
Branches: blender-v3.2-release
https://developer.blender.org/rBbf352df27a6f85d73bc0d6417f50fd62958cfb6e
Fix wrong USD image color space export with non-default OpenColorIO config
The names of color spaces in OpenColorIO configs can be arbitrary, so don't
use hardcoded names from our default config.
===================================================================
M source/blender/imbuf/IMB_colormanagement.h
M source/blender/imbuf/intern/colormanagement.c
M source/blender/io/usd/CMakeLists.txt
M source/blender/io/usd/intern/usd_writer_material.cc
===================================================================
diff --git a/source/blender/imbuf/IMB_colormanagement.h b/source/blender/imbuf/IMB_colormanagement.h
index 97030d44047..1f0ed4cafbe 100644
--- a/source/blender/imbuf/IMB_colormanagement.h
+++ b/source/blender/imbuf/IMB_colormanagement.h
@@ -54,6 +54,7 @@ bool IMB_colormanagement_space_is_scene_linear(struct ColorSpace *colorspace);
bool IMB_colormanagement_space_is_srgb(struct ColorSpace *colorspace);
bool IMB_colormanagement_space_name_is_data(const char *name);
bool IMB_colormanagement_space_name_is_scene_linear(const char *name);
+bool IMB_colormanagement_space_name_is_srgb(const char *name);
/**
* Convert a float RGB triplet to the correct luminance weighted average.
diff --git a/source/blender/imbuf/intern/colormanagement.c b/source/blender/imbuf/intern/colormanagement.c
index 53aa74edc61..95e2d36891a 100644
--- a/source/blender/imbuf/intern/colormanagement.c
+++ b/source/blender/imbuf/intern/colormanagement.c
@@ -1412,6 +1412,12 @@ bool IMB_colormanagement_space_name_is_scene_linear(const char *name)
return (colorspace && IMB_colormanagement_space_is_scene_linear(colorspace));
}
+bool IMB_colormanagement_space_name_is_srgb(const char *name)
+{
+ ColorSpace *colorspace = colormanage_colorspace_get_named(name);
+ return (colorspace && IMB_colormanagement_space_is_srgb(colorspace));
+}
+
const float *IMB_colormanagement_get_xyz_to_rgb()
{
return &imbuf_xyz_to_rgb[0][0];
diff --git a/source/blender/io/usd/CMakeLists.txt b/source/blender/io/usd/CMakeLists.txt
index e2e959814fa..594dbe5ddd1 100644
--- a/source/blender/io/usd/CMakeLists.txt
+++ b/source/blender/io/usd/CMakeLists.txt
@@ -43,6 +43,7 @@ set(INC
../../bmesh
../../depsgraph
../../editors/include
+ ../../imbuf
../../makesdna
../../makesrna
../../windowmanager
@@ -112,6 +113,7 @@ set(SRC
set(LIB
bf_blenkernel
bf_blenlib
+ bf_imbuf
bf_io_common
)
diff --git a/source/blender/io/usd/intern/usd_writer_material.cc b/source/blender/io/usd/intern/usd_writer_material.cc
index 1bfc0e50f69..dd795e4f922 100644
--- a/source/blender/io/usd/intern/usd_writer_material.cc
+++ b/source/blender/io/usd/intern/usd_writer_material.cc
@@ -10,6 +10,8 @@
#include "BKE_main.h"
#include "BKE_node.h"
+#include "IMB_colormanagement.h"
+
#include "BLI_fileops.h"
#include "BLI_linklist.h"
#include "BLI_listbase.h"
@@ -414,13 +416,10 @@ static pxr::TfToken get_node_tex_image_color_space(bNode *node)
Image *ima = reinterpret_cast<Image *>(node->id);
- if (strcmp(ima->colorspace_settings.name, "Raw") == 0) {
- return usdtokens::raw;
- }
- if (strcmp(ima->colorspace_settings.name, "Non-Color") == 0) {
+ if (IMB_colormanagement_space_name_is_data(ima->colorspace_settings.name)) {
return usdtokens::raw;
}
- if (strcmp(ima->colorspace_settings.name, "sRGB") == 0) {
+ if (IMB_colormanagement_space_name_is_srgb(ima->colorspace_settings.name)) {
return usdtokens::sRGB;
}
More information about the Bf-blender-cvs
mailing list