[Bf-blender-cvs] [1af6e0daaf6] blender-v2.93-release: Fix T90772: Image Editor not sampling color from the the currently selected pass
Philipp Oeser
noreply at git.blender.org
Mon Sep 6 09:40:33 CEST 2021
Commit: 1af6e0daaf6ba47c083e9cd451fe145f7545bc79
Author: Philipp Oeser
Date: Thu Aug 19 14:03:48 2021 +0200
Branches: blender-v2.93-release
https://developer.blender.org/rB1af6e0daaf6ba47c083e9cd451fe145f7545bc79
Fix T90772: Image Editor not sampling color from the the currently
selected pass
Caused by {rBebaa3fcedd23}.
Seems this above commit assumed an ImageUser's multi_index is only used
for Multiview/Stereo? This is not the case, multi_index also stores the
index for layer/pass combination.
If we call both BKE_image_multilayer_index and BKE_image_multiview_index
(even though this is not appropriate/needed for multilayer images?), we
might end up overwriting multi_index again.
note: looking at this I was also wondering why we update the ImageUser
in image-buffer-aquiring funnctions [and not from the UI, e.g.
template_image_layers, but that is a whole different story I guess, see
comment in T90772 as well]
note2: this could also use a utility function (this is not the only
place where this is done), this is fo a cleanup commit.
Maniphest Tasks: T90772
Differential Revision: https://developer.blender.org/D12267
===================================================================
M source/blender/draw/engines/image/image_engine.c
===================================================================
diff --git a/source/blender/draw/engines/image/image_engine.c b/source/blender/draw/engines/image/image_engine.c
index 3313494adcc..089ddc8045b 100644
--- a/source/blender/draw/engines/image/image_engine.c
+++ b/source/blender/draw/engines/image/image_engine.c
@@ -111,7 +111,9 @@ static void space_image_gpu_texture_get(Image *image,
/* update multiindex and pass for the current eye */
BKE_image_multilayer_index(image->rr, &sima->iuser);
}
- BKE_image_multiview_index(image, &sima->iuser);
+ else {
+ BKE_image_multiview_index(image, &sima->iuser);
+ }
if (ibuf) {
const int sima_flag = sima->flag & ED_space_image_get_display_channel_mask(ibuf);
More information about the Bf-blender-cvs
mailing list