[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [42322] trunk/blender/source/blender/ makesrna/RNA_access.h: Fix for RNA_warning crashing on MSVC release builds

Andrew Wiggin ender79bl at gmail.com
Thu Dec 1 19:38:07 CET 2011


Revision: 42322
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-blender&revision=42322
Author:   ender79
Date:     2011-12-01 18:38:03 +0000 (Thu, 01 Dec 2011)
Log Message:
-----------
Fix for RNA_warning crashing on MSVC release builds

MSVC is not C99-compliant, but with the macro as it was, the "args" part was consuming and dropping one of the params, so the format string wanted N extra args, and there were only N-1... boom, crash! Without "args" this works correctly (checked on MSVC10 release build)

Modified Paths:
--------------
    trunk/blender/source/blender/makesrna/RNA_access.h

Modified: trunk/blender/source/blender/makesrna/RNA_access.h
===================================================================
--- trunk/blender/source/blender/makesrna/RNA_access.h	2011-12-01 18:36:36 UTC (rev 42321)
+++ trunk/blender/source/blender/makesrna/RNA_access.h	2011-12-01 18:38:03 UTC (rev 42322)
@@ -996,7 +996,7 @@
 #ifdef __GNUC__
 #  define RNA_warning(format, args...) _RNA_warning("%s: " format "\n", __func__, ##args)
 #else
-#  define RNA_warning(format, args, ...) _RNA_warning("%s: " format "\n", __FUNCTION__, __VA_ARGS__)
+#  define RNA_warning(format, ...) _RNA_warning("%s: " format "\n", __FUNCTION__, __VA_ARGS__)
 #endif
 
 void _RNA_warning(const char *format, ...)




More information about the Bf-blender-cvs mailing list