[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [30227] trunk/blender/source/blender/imbuf /intern/openexr/openexr_api.cpp: dont add a rect buffer for EXR's, the sequencer discards them immediately and functions that need a rect should create one on the fly .

Campbell Barton ideasman42 at gmail.com
Mon Jul 12 15:35:02 CEST 2010


Revision: 30227
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=30227
Author:   campbellbarton
Date:     2010-07-12 15:35:00 +0200 (Mon, 12 Jul 2010)

Log Message:
-----------
dont add a rect buffer for EXR's, the sequencer discards them immediately and functions that need a rect should create one on the fly.

this shows a problem with Imbuf where there is no way to ask to only load the native type byte/float.

Modified Paths:
--------------
    trunk/blender/source/blender/imbuf/intern/openexr/openexr_api.cpp

Modified: trunk/blender/source/blender/imbuf/intern/openexr/openexr_api.cpp
===================================================================
--- trunk/blender/source/blender/imbuf/intern/openexr/openexr_api.cpp	2010-07-12 13:25:57 UTC (rev 30226)
+++ trunk/blender/source/blender/imbuf/intern/openexr/openexr_api.cpp	2010-07-12 13:35:00 UTC (rev 30227)
@@ -1011,8 +1011,16 @@
 					
 					file->setFrameBuffer (frameBuffer);
 					file->readPixels (dw.min.y, dw.max.y);
-					
-					IMB_rect_from_float(ibuf);
+
+					// XXX, ImBuf has no nice way to deal with this.
+					// ideally IM_rect would be used when the caller wants a rect BUT
+					// at the moment all functions use IM_rect.
+					// Disabling this is ok because all functions should check if a rect exists and create one on demand.
+					//
+					// Disabling this because the sequencer frees immediate.
+					//
+					// if(flag & IM_rect)
+					//     IMB_rect_from_float(ibuf);
 				}
 			}
 			





More information about the Bf-blender-cvs mailing list