[Bf-blender-cvs] SVN commit: /data/svn/bf-blender [25346] trunk/blender/release/scripts/io/ netrender/balancing.py: netrender balancing fix ( accessing the list as it is being sorted is not ok)

Martin Poirier theeth at yahoo.com
Sun Dec 13 23:24:32 CET 2009


Revision: 25346
          http://projects.blender.org/plugins/scmsvn/viewcvs.php?view=rev&root=bf-blender&revision=25346
Author:   theeth
Date:     2009-12-13 23:24:30 +0100 (Sun, 13 Dec 2009)

Log Message:
-----------
netrender balancing fix (accessing the list as it is being sorted is not ok)

Caused balancing to error when there was only one job (and more generally, to have a slightly wrong result)

Modified Paths:
--------------
    trunk/blender/release/scripts/io/netrender/balancing.py

Modified: trunk/blender/release/scripts/io/netrender/balancing.py
===================================================================
--- trunk/blender/release/scripts/io/netrender/balancing.py	2009-12-13 21:28:31 UTC (rev 25345)
+++ trunk/blender/release/scripts/io/netrender/balancing.py	2009-12-13 22:24:30 UTC (rev 25346)
@@ -72,7 +72,8 @@
 	
 	def balance(self, jobs):
 		if jobs:
-			jobs.sort(key=self.sortKey)
+			# use inline copy to make sure the list is still accessible while sorting
+			jobs[:] = sorted(jobs, key=self.sortKey)
 			return jobs[0]
 		else:
 			return None





More information about the Bf-blender-cvs mailing list