[tuhopuu-devel] Re: [tuhopuu-cvs] CVS commit: tuhopuu3/source/blender/blenkernel BKE_dmesh.h

[Jean-Luc Peuriere]

Le 1 avr. 05, à 02:05, Matt Ebb a écrit :

> On 1 Apr 2005, at 9:26 AM, Chris Want wrote:
>
>> 'Blah!' and 'more...' are not acceptable
>> commit log messages. Please be more
>> descriptive.
>
> Totally agreed.
>
> CVS is not your own personal development tree either - do some work in 
> your own tree until you've achieved something significant, check it, 
> test it, check the diff, then commit it in the one chunk.

Agreed too.

More, both Makefiles and Scons are official build systems. That means 
that when adding new files, you must add them to the sconscripts files 
too. Even if you cannot test, that's will help those who can. You dont 
have to worry about the other systems, they will be handled by their 
respective owners.

Player is still broken. Tuhopuu is an experimental tree, so CVS can 
stay broken a few days but not too long. It is your duty to correct 
this as soon as possible.

It was reported that the lack of prototypes and the implicit 
declarations broke compilation on GCC 3.4. You are still at 337 
warnings on Xcode, which has sane warning options (-Wall 
-Wno-char-subscripts -Wmissing-prototypes with GCC). that's way too 
much (even if all are not yours but at least 3/4) and must be corrected 
as soon as possible. You were given a list.

Especially, implicit declarations and any kind of type mismatch must be 
corrected. Prototypes and static keywords should be given too.

Those points are a real priority, before any new work is added.

-- 
Jean-Luc