[Bf-viewport] OCIO update

[Clément FOUCAULT]

I've looked into OCIO sources and the GPU_LANGUAGE_GLSL_1_3 is only used in
one case to write a function with the "in" qualifier.
Most of the time it's just used to check if it's GLSL code.

https://github.com/imageworks/OpenColorIO/blob/a557a85454ee1ffa8cb66f8a96238e079c452f08/src/core/Processor.cpp#L244

So I'm pretty positive it means GLSL >= 1.3

With your permission, can I update the ocio_impl_glsl.cc
and gpu_shader_display_transform.glsl to glsl 3.3 ?

2017-02-23 10:33 GMT+01:00 Sergey Sharybin <sergey.vfx at gmail.com>:

> Hi Clément,
>
> As far as i can see, gl_texCoord is only used by our own shader in
> intern/opencolorio/gpu_shader_display_transform.glsl. So that part will
> be fairly trivial to update.
>
> The main question currently is: whether any of GLSL code from OCIO side is
> to be changed to meet our requirements?
>
> On Thu, Feb 23, 2017 at 10:28 AM, Clément FOUCAULT <
> foucault.clem at gmail.com> wrote:
>
>> Hi Sergey,
>>
>> OCIO is interleaved with blender's glaDrawPixelsTexScaled_clipping which
>> emit vertices. But ocio uses deprecated gl_texCoord and we can't bind VBOs
>> (now required) to this shader (as far as I know).
>>
>> Steps to update are simple and I can do it already:
>> - Create a vertex shader for OCIO.
>> - Remove builtin gl_texCoord.
>> - Change code that uses glsl OCIO to not change the shader when using
>> OCIO.
>>
>> > Is that because GLSL 1.3 can't be used form inside 3.2 core?
>> I mostly believe that's the case.
>>
>>
>> 2017-02-23 9:40 GMT+01:00 Sergey Sharybin <sergey.vfx at gmail.com>:
>>
>>> Hi,
>>>
>>> We would surely need to support that, but for the time being we can
>>> disable that code fairly easily by returning false
>>> from OCIOImpl::supportGLSLDraw.
>>>
>>> I'm also not really sure what's the exact issue with using current
>>> shaders, those are in their own pipeline which is not interleaved with
>>> "main" viewport drawing pipeline. Is that because GLSL 1.3 can't be used
>>> form inside 3.2 core?
>>>
>>> On Thu, Feb 23, 2017 at 5:27 AM, Mike Erwin <significant.bit at gmail.com>
>>> wrote:
>>>
>>>> Clément brought this up in IRC — OCIO uses older GLSL and needs to be
>>>> updated. Is this something we need now, or can it be a todo task?
>>>>
>>>> Taking a quick look now... seems OCIO can generate GLSL 1.0 or 1.3, and
>>>> we're moving toward GLSL 3.3 for everything.
>>>>
>>>> Mike Erwin
>>>> musician, naturalist, pixel pusher, hacker extraordinaire
>>>>
>>>> _______________________________________________
>>>> Bf-viewport mailing list
>>>> Bf-viewport at blender.org
>>>> https://lists.blender.org/mailman/listinfo/bf-viewport
>>>>
>>>>
>>>
>>>
>>> --
>>> With best regards, Sergey Sharybin
>>>
>>> _______________________________________________
>>> Bf-viewport mailing list
>>> Bf-viewport at blender.org
>>> https://lists.blender.org/mailman/listinfo/bf-viewport
>>>
>>>
>>
>> _______________________________________________
>> Bf-viewport mailing list
>> Bf-viewport at blender.org
>> https://lists.blender.org/mailman/listinfo/bf-viewport
>>
>>
>
>
> --
> With best regards, Sergey Sharybin
>
> _______________________________________________
> Bf-viewport mailing list
> Bf-viewport at blender.org
> https://lists.blender.org/mailman/listinfo/bf-viewport
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-viewport/attachments/20170223/6004353a/attachment.htm