[Bf-taskforce25] 2.5 branch temporary UNSAFE!

Shaul Kedem shaul.kedem at gmail.com
Sat Jan 17 16:32:31 CET 2009


In such cases, can the branch be closed for anonymous reads?

On Sat, Jan 17, 2009 at 10:02 AM, Ton Roosendaal <ton at blender.org> wrote:
> Hi,
>
> Warning; Joshuas commit will make reading files with Actions go
> horrible wrong.
> Do not attempt even, nor save such files. Should be fixed tomorrow.
>
> Joshua: if you want nAction to reside next to bAction, for conversions,
> you have to give nAction an own unique ID (DNA_ID.h), and add it to the
> Main (BKE_main.h), and make sure library lists recognize it
> (library.c:set_listbasepointers), and it can be found
> (library.c:which_libbase), allocated (library.c:alloc_libblock_notest)
> and freed (library.c: free_libblock).
>
> Also readfile.c should get this, and so on...
>
> I also noticed in your new code that freeing memory is not 100%
> failsafe... you should tag functions clearly whether or not they're
> supposed to free the data itself, and if not, always leave the pointers
> after free NULL. Do not free lists without a BLI_remlink()!
>
> -Ton-
>
> ------------------------------------------------------------------------
> Ton Roosendaal  Blender Foundation   ton at blender.org    www.blender.org
> Blender Institute BV  Entrepotdok 57A  1018AD Amsterdam The Netherlands
>
> _______________________________________________
> Bf-taskforce25 mailing list
> Bf-taskforce25 at blender.org
> http://lists.blender.org/mailman/listinfo/bf-taskforce25
>


More information about the Bf-taskforce25 mailing list