[Bf-python] Final Revision

[joeedh]

Stephen Swaney wrote:

>On Tue, Feb 22, 2005 at 06:24:31PM -0700, Austin Benesh wrote:
>  
>
>>Okay, this is the final revision for my first patch. :-)
>>    
>>
>
>Some thoughts:
>
>
>  
>
>>+/* FUNCTION GET PIXELS NEEDED DESPERATELY*/
>>    
>>
>
>  
>
>>+	// desperately needed...
>>    
>>
>
>1) I don't quite understand how these comments help future maintainers of
>the code understand what is going on.
>
>
>
>  
>
>>+	if( !image->ibuf||!image->ibuf->rect )	/* if no image data available */
>>    
>>
>
>  
>
>>+	if( !image->ibuf||!image->ibuf->rect )	/* didn't work */
>>    
>>
>
>  
>
>>+	if(x>image->ibuf->x||y>image->ibuf->y||image->ibuf->xorig>x||image->ibuf->yorig>y)
>>    
>>
>
>2) Stuff like this is *really* hard to read.  Using a little white
>space or some parens would go a long way.  This is important because
>code is read much more than it is written.
>
>3) You don't need to post patches to both bf-committers and
>bf-bpython.  Just bf-python will do nicely.
>
I don't really think that this is a good idea, IMHO.  The self-contained 
nature of the python dev team has lead to some design conflicts, and as 
such I think it would be a good idea if all patches were sent to both lists.

Willian, Stephen, what do you think?

Just my .2 cents.
joeedh