[Bf-python] Final Revision

[Stephen Swaney]

On Tue, Feb 22, 2005 at 06:24:31PM -0700, Austin Benesh wrote:
> Okay, this is the final revision for my first patch. :-)

Some thoughts:


> +/* FUNCTION GET PIXELS NEEDED DESPERATELY*/

> +	// desperately needed...

1) I don't quite understand how these comments help future maintainers of
the code understand what is going on.



> +	if( !image->ibuf||!image->ibuf->rect )	/* if no image data available */

> +	if( !image->ibuf||!image->ibuf->rect )	/* didn't work */

> +	if(x>image->ibuf->x||y>image->ibuf->y||image->ibuf->xorig>x||image->ibuf->yorig>y)

2) Stuff like this is *really* hard to read.  Using a little white
space or some parens would go a long way.  This is important because
code is read much more than it is written.

3) You don't need to post patches to both bf-committers and
bf-bpython.  Just bf-python will do nicely.

4) Combing the patches for Image.c and Image.py is a good thing.

-- 
Stephen Swaney			
sswaney at centurytel.net