[Bf-modeling] Vertex Beveling with Two Edge Verts

[Jonathan Williamson]

Thanks Howard!

Jonathan Williamson
http://cgcookie.com


On Fri, Sep 20, 2013 at 7:53 AM, Howard Trickey <howard.trickey at gmail.com>wrote:

> Jonathan,
>
> For now I just submitted Walid's patch (with an extra change to avoid
> tripping an assert
> when someone tries segments > 1) (r60264). The case with segments > 1
> would be useful
> to handle with rounding but I should work on my knife and bevel bugs in
> tracker
> before doing any more on this feature request.
>
> - Howard
>
>
>
> On Thu, Sep 19, 2013 at 10:33 AM, Jonathan Williamson <
> jonathan at cgcookie.com> wrote:
>
>> Howard,
>>
>> I haven't been able to test the above change yet, need to get my
>> compiling fixed for the new XCode, but if a new algorithm could account for
>> those cases that otherwise would fail, then I think this is the way to go.
>>
>> Even though I would love to simply have it working right now, for a
>> better user experience it'd be nice to cover more corner cases.
>>
>>  Jonathan Williamson
>> http://cgcookie.com
>>
>>
>> On Fri, Sep 13, 2013 at 6:16 AM, Howard Trickey <howard.trickey at gmail.com
>> > wrote:
>>
>>> Walid's patch, to my amazement, does in fact make the case of beveling
>>> vertices that are outside corners of faces work as desired.  I'm amazed
>>> because the algorithm for vertex beveling was designed only to handle the
>>> case of beveling an interior vertex.
>>>
>>> We could commit this change, but it would expose other cases where
>>> beveling a valence-2 vertex doesn't work because the algorithm wasn't
>>> designed to:
>>> 1) segments > 1
>>> 2) the valence-2 vertex is in the interior of a face.
>>>
>>> I or someone could write a different algorithm for handling
>>> external-face corners with segments > 1, and do something for the interior
>>> case.  Question is, should we wait until that is done or commit the above
>>> change now?
>>>
>>> - Howard
>>>
>>>
>>> On Thu, Sep 12, 2013 at 9:35 PM, walid shouman <
>>> eng.walidshouman at gmail.com> wrote:
>>>
>>>> believe that would make it fixed ... but i wouldn't risk applying the
>>>> patch till Campbell approves it
>>>>
>>>> for the time being its working well in my version
>>>>
>>>> Index: source/blender/bmesh/tools/bmesh_bevel.c
>>>> ===================================================================
>>>> --- source/blender/bmesh/tools/bmesh_bevel.c    (revision 59907)
>>>> +++ source/blender/bmesh/tools/bmesh_bevel.c    (working copy)
>>>> @@ -1962,7 +1962,7 @@
>>>>      if (!first_bme)
>>>>          first_bme = v->e;
>>>>
>>>> -    if ((nsel == 0 && !bp->vertex_only) || (ntot < 3 &&
>>>> bp->vertex_only)) {
>>>> +    if ((nsel == 0 && !bp->vertex_only) || (ntot < 2 &&
>>>> bp->vertex_only)) {
>>>>          /* signal this vert isn't being beveled */
>>>>          BM_elem_flag_disable(v, BM_ELEM_TAG);
>>>>          return;
>>>>
>>>> On Fri, Sep 13, 2013 at 1:02 AM, Jonathan Williamson
>>>> <jonathan at cgcookie.com> wrote:
>>>> > Hey Campbell,
>>>> >
>>>> > Currently vertex bevel does not support beveling on vertices with
>>>> only two
>>>> > edges. Vertices much have three or more edges connected to it to
>>>> bevel.
>>>> >
>>>> > Is it possible to remove this limitation? In cases like this, where I
>>>> want
>>>> > to bevel the tips it'd be very useful: http://cl.ly/RMNA
>>>> >
>>>> > Using the above, beveling would allow me to make this quickly:
>>>> > http://cl.ly/RNAM
>>>> >
>>>> > Jonathan Williamson
>>>> > http://cgcookie.com
>>>> >
>>>> > _______________________________________________
>>>> > Bf-modeling mailing list
>>>> > Bf-modeling at blender.org
>>>> > http://lists.blender.org/mailman/listinfo/bf-modeling
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Sincerely,
>>>> Walid E. Shouman
>>>> Third year, CSE department, ASU.
>>>> ACES'12 Media Vice-Head.
>>>> Al-Manara kids instructor.
>>>> CORD EGY'11 Vice-Director.
>>>> Al-Shams Scouting Team Rover Scout.
>>>> _______________________________________________
>>>> Bf-modeling mailing list
>>>> Bf-modeling at blender.org
>>>> http://lists.blender.org/mailman/listinfo/bf-modeling
>>>>
>>>
>>>
>>> _______________________________________________
>>> Bf-modeling mailing list
>>> Bf-modeling at blender.org
>>> http://lists.blender.org/mailman/listinfo/bf-modeling
>>>
>>>
>>
>> _______________________________________________
>> Bf-modeling mailing list
>> Bf-modeling at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-modeling
>>
>>
>
> _______________________________________________
> Bf-modeling mailing list
> Bf-modeling at blender.org
> http://lists.blender.org/mailman/listinfo/bf-modeling
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.blender.org/pipermail/bf-modeling/attachments/20130924/1a38e6a1/attachment.html>