[Bf-extensions-cvs] [7c0d4de1] master: glTF exporter: Fix default sheen factors

Julien Duroure noreply at git.blender.org
Mon Sep 19 08:49:03 CEST 2022


Commit: 7c0d4de11721bd93afc64e0cf63cc84807c5c305
Author: Julien Duroure
Date:   Mon Sep 19 08:48:45 2022 +0200
Branches: master
https://developer.blender.org/rBA7c0d4de11721bd93afc64e0cf63cc84807c5c305

glTF exporter: Fix default sheen factors

===================================================================

M	io_scene_gltf2/__init__.py
M	io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py

===================================================================

diff --git a/io_scene_gltf2/__init__.py b/io_scene_gltf2/__init__.py
index f0f71dfc..fba51d41 100755
--- a/io_scene_gltf2/__init__.py
+++ b/io_scene_gltf2/__init__.py
@@ -4,7 +4,7 @@
 bl_info = {
     'name': 'glTF 2.0 format',
     'author': 'Julien Duroure, Scurest, Norbert Nopper, Urs Hanselmann, Moritz Becher, Benjamin Schmithüsen, Jim Eckerlein, and many external contributors',
-    "version": (3, 4, 11),
+    "version": (3, 4, 12),
     'blender': (3, 3, 0),
     'location': 'File > Import-Export',
     'description': 'Import-Export as glTF 2.0',
diff --git a/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py b/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py
index 03625ecb..1d4fb5b9 100644
--- a/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py
+++ b/io_scene_gltf2/blender/exp/gltf2_blender_gather_materials_sheen.py
@@ -29,6 +29,8 @@ def export_sheen(blender_material, export_settings):
     else:
         # Factor
         fac = gltf2_blender_get.get_factor_from_socket(sheenColor_socket, kind='RGB')
+        if fac is None:
+            fac = [1.0, 1.0, 1.0] # Default is 0.0/0.0/0.0, so we need to set it to 1 if no factor
         if fac is not None and fac != [0.0, 0.0, 0.0]:
             sheen_extension['sheenColorFactor'] = fac
         
@@ -51,6 +53,8 @@ def export_sheen(blender_material, export_settings):
     else:
         # Factor
         fac = gltf2_blender_get.get_factor_from_socket(sheenRoughness_socket, kind='VALUE')
+        if fac is None:
+            fac = 1.0 # Default is 0.0 so we need to set it to 1.0 if no factor
         if fac is not None and fac != 0.0:
             sheen_extension['sheenRoughnessFactor'] = fac



More information about the Bf-extensions-cvs mailing list