[Bf-extensions-cvs] [4be7119a] master: glTF exporter: Fix T102066: typo - fix crash exporting with tangents

Julien Duroure noreply at git.blender.org
Wed Oct 26 06:11:21 CEST 2022


Commit: 4be7119ac5a72fb27b9ca98e08bd66d234c4cf0e
Author: Julien Duroure
Date:   Wed Oct 26 06:11:16 2022 +0200
Branches: master
https://developer.blender.org/rBA4be7119ac5a72fb27b9ca98e08bd66d234c4cf0e

glTF exporter: Fix T102066: typo - fix crash exporting with tangents

===================================================================

M	io_scene_gltf2/__init__.py
M	io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py

===================================================================

diff --git a/io_scene_gltf2/__init__.py b/io_scene_gltf2/__init__.py
index 08260263..94881019 100755
--- a/io_scene_gltf2/__init__.py
+++ b/io_scene_gltf2/__init__.py
@@ -4,7 +4,7 @@
 bl_info = {
     'name': 'glTF 2.0 format',
     'author': 'Julien Duroure, Scurest, Norbert Nopper, Urs Hanselmann, Moritz Becher, Benjamin Schmithüsen, Jim Eckerlein, and many external contributors',
-    "version": (3, 4, 40),
+    "version": (3, 4, 41),
     'blender': (3, 3, 0),
     'location': 'File > Import-Export',
     'description': 'Import-Export as glTF 2.0',
diff --git a/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py b/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py
index 3e69c2c8..f823d176 100644
--- a/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py
+++ b/io_scene_gltf2/blender/exp/gltf2_blender_gather_primitives_extract.py
@@ -747,7 +747,7 @@ class PrimitiveCreator:
 
     def __get_bitangent_signs(self):
         self.signs = np.empty(len(self.blender_mesh.loops), dtype=np.float32)
-        self.blender_mesh.loops.foreach_get('bitangent_sign', signs)
+        self.blender_mesh.loops.foreach_get('bitangent_sign', self.signs)
 
         # Transform for skinning
         if self.armature and self.blender_object:
@@ -757,7 +757,7 @@ class PrimitiveCreator:
             tangent_transform = apply_matrix.to_quaternion().to_matrix()
             flipped = tangent_transform.determinant() < 0
             if flipped:
-                signs *= -1
+                self.signs *= -1
 
         # No change for Zup -> Yup



More information about the Bf-extensions-cvs mailing list