[Bf-extensions-cvs] [0e3978e1] blender-v3.3-release: Fix: nodewrangler error accessing space.node_tree when not available

Philipp Oeser noreply at git.blender.org
Thu Aug 25 09:28:29 CEST 2022


Commit: 0e3978e17a45b95ad746b8090ac11fafc9ba6886
Author: Philipp Oeser
Date:   Wed Aug 24 11:14:17 2022 +0200
Branches: blender-v3.3-release
https://developer.blender.org/rBA0e3978e17a45b95ad746b8090ac11fafc9ba6886

Fix: nodewrangler error accessing space.node_tree when not available

Revert part of rBAad1966474ed2 in nw_check() which was giving no benefit
afaict (and instead tried to access space.node_tree for Spaces other
than the Node Editor, spamming the console with errors).

Differential Revision: https://developer.blender.org/D15770

===================================================================

M	node_wrangler.py

===================================================================

diff --git a/node_wrangler.py b/node_wrangler.py
index 290ac082..cc1b85fe 100644
--- a/node_wrangler.py
+++ b/node_wrangler.py
@@ -830,12 +830,13 @@ class NWNodeWrangler(bpy.types.AddonPreferences):
 
 def nw_check(context):
     space = context.space_data
-    editor_is_valid = space.type == 'NODE_EDITOR'
-
     valid_trees = ["ShaderNodeTree", "CompositorNodeTree", "TextureNodeTree", "GeometryNodeTree"]
-    tree_is_valid = space.node_tree is not None and space.tree_type in valid_trees
 
-    return editor_is_valid and tree_is_valid
+    valid = False
+    if space.type == 'NODE_EDITOR' and space.node_tree is not None and space.tree_type in valid_trees:
+        valid = True
+
+    return valid
 
 class NWBase:
     @classmethod



More information about the Bf-extensions-cvs mailing list