[Bf-extensions-cvs] [f8e313f6] master: glTF importer: perf: use foreach_set to set interpolation in fcurves

Julien Duroure noreply at git.blender.org
Thu Sep 17 15:23:14 CEST 2020


Commit: f8e313f6267742a10b8df07977182e179fa0e6f4
Author: Julien Duroure
Date:   Wed Sep 16 18:04:37 2020 +0200
Branches: master
https://developer.blender.org/rBAf8e313f6267742a10b8df07977182e179fa0e6f4

glTF importer: perf: use foreach_set to set interpolation in fcurves

===================================================================

M	io_scene_gltf2/__init__.py
M	io_scene_gltf2/blender/imp/gltf2_blender_animation_utils.py

===================================================================

diff --git a/io_scene_gltf2/__init__.py b/io_scene_gltf2/__init__.py
index 6e5868ab..873b844d 100755
--- a/io_scene_gltf2/__init__.py
+++ b/io_scene_gltf2/__init__.py
@@ -15,7 +15,7 @@
 bl_info = {
     'name': 'glTF 2.0 format',
     'author': 'Julien Duroure, Scurest, Norbert Nopper, Urs Hanselmann, Moritz Becher, Benjamin Schmithüsen, Jim Eckerlein, and many external contributors',
-    "version": (1, 4, 26),
+    "version": (1, 4, 27),
     'blender': (2, 90, 0),
     'location': 'File > Import-Export',
     'description': 'Import-Export as glTF 2.0',
diff --git a/io_scene_gltf2/blender/imp/gltf2_blender_animation_utils.py b/io_scene_gltf2/blender/imp/gltf2_blender_animation_utils.py
index c45e7f7d..649e5900 100644
--- a/io_scene_gltf2/blender/imp/gltf2_blender_animation_utils.py
+++ b/io_scene_gltf2/blender/imp/gltf2_blender_animation_utils.py
@@ -56,20 +56,19 @@ def make_fcurve(action, co, data_path, index=0, group_name='', interpolation=Non
     fcurve.keyframe_points.foreach_set('co', co)
 
     # Setting interpolation
+    ipo = {
+        'CUBICSPLINE': 'BEZIER',
+        'LINEAR': 'LINEAR',
+        'STEP': 'CONSTANT',
+    }[interpolation or 'LINEAR']
+    ipo = bpy.types.Keyframe.bl_rna.properties['interpolation'].enum_items[ipo].value
+    fcurve.keyframe_points.foreach_set('interpolation', [ipo] * len(fcurve.keyframe_points))
+
+    # For CUBICSPLINE, also set the handle types to AUTO
     if interpolation == 'CUBICSPLINE':
-        for kf in fcurve.keyframe_points:
-            kf.interpolation = 'BEZIER'
-            kf.handle_right_type = 'AUTO'
-            kf.handle_left_type = 'AUTO'
-    else:
-        if interpolation == 'LINEAR':
-            blender_interpolation = 'LINEAR'
-        elif interpolation == 'STEP':
-            blender_interpolation = 'CONSTANT'
-        else:
-            blender_interpolation = 'LINEAR'
-        for kf in fcurve.keyframe_points:
-            kf.interpolation = blender_interpolation
+        ty = bpy.types.Keyframe.bl_rna.properties['handle_left_type'].enum_items['AUTO'].value
+        fcurve.keyframe_points.foreach_set('handle_left_type', [ty] * len(fcurve.keyframe_points))
+        fcurve.keyframe_points.foreach_set('handle_right_type', [ty] * len(fcurve.keyframe_points))
 
     fcurve.update() # force updating tangents (this may change when tangent will be managed)



More information about the Bf-extensions-cvs mailing list