[Bf-extensions-cvs] [05ce40e6] master: Print3D: Fix (unreported) error in Make Manifold tool

Mikhail Rachinskiy noreply at git.blender.org
Wed Sep 18 18:12:03 CEST 2019


Commit: 05ce40e6afc5c4266863ddf537309ed09e78ef9f
Author: Mikhail Rachinskiy
Date:   Wed Sep 18 20:11:52 2019 +0400
Branches: master
https://developer.blender.org/rBA05ce40e6afc5c4266863ddf537309ed09e78ef9f

Print3D: Fix (unreported) error in Make Manifold tool

Remove redundant boundary fill step which gave the error when there was no boundary selected. Make sides property default to 0 so fill holes will cover for boundary fill absence.

===================================================================

M	object_print3d_utils/operators.py

===================================================================

diff --git a/object_print3d_utils/operators.py b/object_print3d_utils/operators.py
index 6d310f3b..fdbc49ba 100644
--- a/object_print3d_utils/operators.py
+++ b/object_print3d_utils/operators.py
@@ -434,7 +434,7 @@ class MESH_OT_Print3D_Clean_Non_Manifold(Operator):
     sides: bpy.props.IntProperty(
         name="sides",
         description="Number of sides in hole required to fill",
-        default=4,
+        default=0,
     )
 
     def execute(self, context):
@@ -553,10 +553,6 @@ class MESH_OT_Print3D_Clean_Non_Manifold(Operator):
         bpy.ops.mesh.select_all(action='SELECT')
         bpy.ops.mesh.fill_holes(sides=sides)
 
-        # fill selected edge faces, which could be additional holes
-        cls.select_non_manifold_verts(use_boundary=True)
-        bpy.ops.mesh.fill()
-
     @classmethod
     def delete_newly_generated_non_manifold_verts(cls):
         """delete any newly generated vertices from the filling repair"""



More information about the Bf-extensions-cvs mailing list