[Bf-extensions-cvs] [d892f8a9] blender-v2.81-release: glTF: code cleanup, remove import *

Julien Duroure noreply at git.blender.org
Tue Oct 15 20:38:15 CEST 2019


Commit: d892f8a96e6b87e0e31dd4ce79deafee0a6a060c
Author: Julien Duroure
Date:   Tue Oct 15 20:37:44 2019 +0200
Branches: blender-v2.81-release
https://developer.blender.org/rBAd892f8a96e6b87e0e31dd4ce79deafee0a6a060c

glTF: code cleanup, remove import *

===================================================================

M	io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
M	io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py

===================================================================

diff --git a/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py b/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
index fe29ebc3..57679d90 100644
--- a/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
+++ b/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
@@ -12,8 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-# FIXME, this goes against Blender's best practice.
-from io_scene_gltf2.io.com.gltf2_io import *
+from io_scene_gltf2.io.com.gltf2_io import from_dict, from_union, from_none, from_float, from_str, from_list
+from io_scene_gltf2.io.com.gltf2_io import to_float, to_class
 
 
 class LightSpot:
@@ -74,3 +74,4 @@ class Light:
                                           self.extensions)
         result["extras"] = self.extras
         return result
+
diff --git a/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py b/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
index 0230bdfc..51920641 100644
--- a/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
+++ b/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
@@ -14,10 +14,7 @@
 
 import bpy
 import sys
-
-# FIXME, this goes against Blender's best practice.
-from ctypes import *
-
+from ctypes import c_void_p, c_uint32, c_uint64, c_bool, c_char_p, cdll
 from pathlib import Path
 
 from io_scene_gltf2.io.exp.gltf2_io_binary_data import BinaryData
@@ -243,3 +240,4 @@ def __compress_primitive(primitive, dll, export_settings):
     dll.disposeCompressor(compressor)
 
     pass
+



More information about the Bf-extensions-cvs mailing list