[Bf-extensions-cvs] [0c21df4e] blender-v2.81-release: Add warnings about non-compliant imports

Campbell Barton noreply at git.blender.org
Tue Oct 15 10:43:17 CEST 2019


Commit: 0c21df4e49166d7aa0b7606db0f9e34ab93a7b68
Author: Campbell Barton
Date:   Tue Oct 15 19:42:17 2019 +1100
Branches: blender-v2.81-release
https://developer.blender.org/rBA0c21df4e49166d7aa0b7606db0f9e34ab93a7b68

Add warnings about non-compliant imports

This makes code harder to maintain & should be resolved
since this add-on is now on by default.

===================================================================

M	io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
M	io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py

===================================================================

diff --git a/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py b/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
index 3dc8704c..fe29ebc3 100644
--- a/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
+++ b/io_scene_gltf2/io/com/gltf2_io_lights_punctual.py
@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# FIXME, this goes against Blender's best practice.
 from io_scene_gltf2.io.com.gltf2_io import *
 
 
@@ -73,4 +74,3 @@ class Light:
                                           self.extensions)
         result["extras"] = self.extras
         return result
-
diff --git a/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py b/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
index 2d42ce10..0230bdfc 100644
--- a/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
+++ b/io_scene_gltf2/io/exp/gltf2_io_draco_compression_extension.py
@@ -14,7 +14,10 @@
 
 import bpy
 import sys
+
+# FIXME, this goes against Blender's best practice.
 from ctypes import *
+
 from pathlib import Path
 
 from io_scene_gltf2.io.exp.gltf2_io_binary_data import BinaryData
@@ -240,4 +243,3 @@ def __compress_primitive(primitive, dll, export_settings):
     dll.disposeCompressor(compressor)
 
     pass
-



More information about the Bf-extensions-cvs mailing list