[Bf-extensions-cvs] [5671b3f5] master: glTF exporter: Fix punctual light export

Julien Duroure noreply at git.blender.org
Thu May 16 21:27:46 CEST 2019


Commit: 5671b3f53b705ed94a153d157b38de94a349fc19
Author: Julien Duroure
Date:   Thu May 16 21:26:33 2019 +0200
Branches: master
https://developer.blender.org/rBA5671b3f53b705ed94a153d157b38de94a349fc19

glTF exporter: Fix punctual light export

Data was not freed correctly, so lights could be exported multiple times

===================================================================

M	io_scene_gltf2/__init__.py
M	io_scene_gltf2/blender/exp/gltf2_blender_gltf2_exporter.py

===================================================================

diff --git a/io_scene_gltf2/__init__.py b/io_scene_gltf2/__init__.py
index cacf2dca..9eb9e86c 100755
--- a/io_scene_gltf2/__init__.py
+++ b/io_scene_gltf2/__init__.py
@@ -15,7 +15,7 @@
 bl_info = {
     'name': 'glTF 2.0 format',
     'author': 'Julien Duroure, Norbert Nopper, Urs Hanselmann, Moritz Becher, Benjamin Schmithüsen, Jim Eckerlein, and many external contributors',
-    "version": (0, 9, 8),
+    "version": (0, 9, 9),
     'blender': (2, 80, 0),
     'location': 'File > Import-Export',
     'description': 'Import-Export as glTF 2.0',
diff --git a/io_scene_gltf2/blender/exp/gltf2_blender_gltf2_exporter.py b/io_scene_gltf2/blender/exp/gltf2_blender_gltf2_exporter.py
index 2fd0f52c..3704d6db 100755
--- a/io_scene_gltf2/blender/exp/gltf2_blender_gltf2_exporter.py
+++ b/io_scene_gltf2/blender/exp/gltf2_blender_gltf2_exporter.py
@@ -229,7 +229,7 @@ class GlTF2Exporter:
         return name + image.file_extension
 
     @classmethod
-    def __get_key_path(cls, d: dict, keypath: List[str], default=[]):
+    def __get_key_path(cls, d: dict, keypath: List[str], default):
         """Create if necessary and get the element at key path from a dict"""
         key = keypath.pop(0)
 
@@ -302,7 +302,7 @@ class GlTF2Exporter:
             # extensions that lie in the root of the glTF.
             # They need to be converted to a reference at place of occurrence
             if isinstance(node, gltf2_io_extensions.ChildOfRootExtension):
-                root_extension_list = self.__get_key_path(self.__gltf.extensions, [node.name] + node.path)
+                root_extension_list = self.__get_key_path(self.__gltf.extensions, [node.name] + node.path, [])
                 idx = self.__append_unique_and_get_index(root_extension_list, extension)
                 return idx



More information about the Bf-extensions-cvs mailing list