[Bf-extensions-cvs] SVN commit: /data/svn/bf-extensions [2683] contrib/py/scripts/addons/ io_import_pdb_atomic_blender.py: remove var which only stores the list size

Campbell Barton ideasman42 at gmail.com
Tue Nov 29 23:45:56 CET 2011


Revision: 2683
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-extensions&revision=2683
Author:   campbellbarton
Date:     2011-11-29 22:45:56 +0000 (Tue, 29 Nov 2011)
Log Message:
-----------
remove var which only stores the list size

Modified Paths:
--------------
    contrib/py/scripts/addons/io_import_pdb_atomic_blender.py

Modified: contrib/py/scripts/addons/io_import_pdb_atomic_blender.py
===================================================================
--- contrib/py/scripts/addons/io_import_pdb_atomic_blender.py	2011-11-29 22:04:54 UTC (rev 2682)
+++ contrib/py/scripts/addons/io_import_pdb_atomic_blender.py	2011-11-29 22:45:56 UTC (rev 2683)
@@ -192,8 +192,6 @@
 (106,         "Stick",    "Stick", (  0.5,   0.5,   0.5), 1.00, 1.00, 1.00),
 ]
 
-ATOM_PDB_ELEMENTS_NUMBER = 106
-
 # A list of ALL objects which are loaded (needed for selected the loaded
 # structure. 
 LOADED_STRUCTURE = []
@@ -1058,8 +1056,9 @@
                     atom_name.append(str.upper(short_name))
 
                 # Default values for the atom.
-                atom_R.append(float(ATOM_PDB_ELEMENTS[ATOM_PDB_ELEMENTS_NUMBER-2][4+int(radiustype)]))
-                atom_color.append(ATOM_PDB_ELEMENTS[ATOM_PDB_ELEMENTS_NUMBER-2][3])        
+                # XXX, whats so special about second last item?
+                atom_R.append(float(ATOM_PDB_ELEMENTS[-2][4 + int(radiustype)]))
+                atom_color.append(ATOM_PDB_ELEMENTS[-2][3])        
         
             # x,y and z are at fixed positions in the PDB file.
             x = float(line[30:38].rsplit()[0])
@@ -1507,8 +1506,8 @@
         # color is taken from the all_atom list, it is the last entry
         # in the data file (index -1).
         bpy.ops.object.material_slot_add()
-        stick_material = bpy.data.materials.new(ATOM_PDB_ELEMENTS[ATOM_PDB_ELEMENTS_NUMBER-1][2])  
-        stick_material.diffuse_color = ATOM_PDB_ELEMENTS[ATOM_PDB_ELEMENTS_NUMBER-1][3]
+        stick_material = bpy.data.materials.new(ATOM_PDB_ELEMENTS[-1][2])  
+        stick_material.diffuse_color = ATOM_PDB_ELEMENTS[-1][3]
  
         # This is the unit vector of the z axis
         z_axis_vec = Vector((0.0, 0.0, 1.0))
@@ -1542,7 +1541,7 @@
             # ... and rotate the stick.
             stick.rotation_euler  = euler
             stick.active_material = stick_material
-            stick.name = ATOM_PDB_ELEMENTS[ATOM_PDB_ELEMENTS_NUMBER-1][1]
+            stick.name = ATOM_PDB_ELEMENTS[-1][1]
             sticks.append(stick)
             
         # 'Group' the stuff   



More information about the Bf-extensions-cvs mailing list