[Bf-extensions-cvs] SVN commit: /data/svn/bf-extensions [1664] trunk/py/scripts/addons: replace imports from *, considered bad practice by python devs.

Campbell Barton ideasman42 at gmail.com
Sun Feb 27 16:27:55 CET 2011


Revision: 1664
          http://projects.blender.org/scm/viewvc.php?view=rev&root=bf-extensions&revision=1664
Author:   campbellbarton
Date:     2011-02-27 15:27:55 +0000 (Sun, 27 Feb 2011)
Log Message:
-----------
replace imports from *, considered bad practice by python devs.

Modified Paths:
--------------
    trunk/py/scripts/addons/io_anim_bvh/__init__.py
    trunk/py/scripts/addons/io_anim_camera.py
    trunk/py/scripts/addons/io_curve_svg/__init__.py
    trunk/py/scripts/addons/io_import_scene_lwo.py
    trunk/py/scripts/addons/io_import_scene_mhx.py
    trunk/py/scripts/addons/io_mesh_ply/__init__.py
    trunk/py/scripts/addons/io_mesh_stl/__init__.py
    trunk/py/scripts/addons/io_scene_3ds/__init__.py
    trunk/py/scripts/addons/io_scene_fbx/__init__.py
    trunk/py/scripts/addons/io_scene_m3/__init__.py
    trunk/py/scripts/addons/io_scene_obj/__init__.py
    trunk/py/scripts/addons/io_scene_x3d/__init__.py
    trunk/py/scripts/addons/io_shape_mdd/__init__.py
    trunk/py/scripts/addons/render_povray/__init__.py
    trunk/py/scripts/addons/space_view3d_copy_attributes.py

Modified: trunk/py/scripts/addons/io_anim_bvh/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_anim_bvh/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_anim_bvh/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -38,7 +38,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, FloatProperty, IntProperty, BoolProperty, EnumProperty
 from io_utils import ImportHelper, ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_anim_camera.py
===================================================================
--- trunk/py/scripts/addons/io_anim_camera.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_anim_camera.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -114,7 +114,7 @@
         fw("\n")
 
 
-from bpy.props import *
+from bpy.props import StringProperty, IntProperty, BoolProperty
 from io_utils import ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_curve_svg/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_curve_svg/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_curve_svg/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -42,7 +42,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty
 from io_utils import ImportHelper, ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_import_scene_lwo.py
===================================================================
--- trunk/py/scripts/addons/io_import_scene_lwo.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_import_scene_lwo.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -1209,7 +1209,7 @@
     print("Done Importing LWO File")
 
 
-from bpy.props import *
+from bpy.props import StringProperty, BoolProperty
 
 
 class IMPORT_OT_lwo(bpy.types.Operator):

Modified: trunk/py/scripts/addons/io_import_scene_mhx.py
===================================================================
--- trunk/py/scripts/addons/io_import_scene_mhx.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_import_scene_mhx.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -66,7 +66,7 @@
 import os
 import time
 import mathutils
-from mathutils import *
+from mathutils import Matrix
 #import geometry
 #import string
 
@@ -2144,7 +2144,7 @@
         elif key == 'Bend':
             axis = val[1]
             angle = float(val[2])
-            mat = mathutils.Matrix.Rotation(angle, 4, axis)
+            mat = Matrix.Rotation(angle, 4, axis)
             try:
                 pb = pbones[val[0]]
                 prod = pb.matrix_local * mat
@@ -2602,8 +2602,8 @@
 #    User interface
 #
 
-DEBUG= False
-from bpy.props import *
+DEBUG = False
+from bpy.props import StringProperty, FloatProperty, EnumProperty
 from io_utils import ImportHelper
 
 

Modified: trunk/py/scripts/addons/io_mesh_ply/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_mesh_ply/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_mesh_ply/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -41,7 +41,7 @@
 
 import os
 import bpy
-from bpy.props import *
+from bpy.props import CollectionProperty, StringProperty, BoolProperty
 from io_utils import ImportHelper, ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_mesh_stl/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_mesh_stl/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_mesh_stl/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -51,17 +51,15 @@
 
 if "bpy" in locals():
     import imp
-    imp.reload(stl_utils)
-    imp.reload(blender_utils)
-else:
-    from . import stl_utils
-    from . import blender_utils
+    if "stl_utils" in locals():
+        imp.reload(stl_utils)
+    if "blender_utils" in locals():
+        imp.reload(blender_utils)
 
-import itertools
 import os
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, BoolProperty, CollectionProperty
 from io_utils import ExportHelper, ImportHelper
 
 
@@ -82,6 +80,9 @@
     directory = StringProperty()
 
     def execute(self, context):
+        from . import stl_utils
+        from . import blender_utils
+
         paths = [os.path.join(self.directory, name.name) for name in self.files]
 
         if not paths:
@@ -114,6 +115,10 @@
                                    default=True)
 
     def execute(self, context):
+        from . import stl_utils
+        from . import blender_utils
+        import itertools
+
         faces = itertools.chain.from_iterable(
             blender_utils.faces_from_mesh(ob, self.apply_modifiers)
             for ob in context.selected_objects)

Modified: trunk/py/scripts/addons/io_scene_3ds/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_scene_3ds/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_scene_3ds/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -40,7 +40,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, FloatProperty, BoolProperty
 from io_utils import ImportHelper, ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_scene_fbx/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_scene_fbx/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_scene_fbx/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -40,7 +40,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, BoolProperty, FloatProperty
 from io_utils import ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_scene_m3/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_scene_m3/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_scene_m3/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -46,7 +46,7 @@
 import time
 import datetime
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, BoolProperty
 from io_utils import ImportHelper, ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_scene_obj/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_scene_obj/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_scene_obj/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -40,7 +40,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import BoolProperty, FloatProperty, StringProperty
 from io_utils import ExportHelper, ImportHelper
 
 

Modified: trunk/py/scripts/addons/io_scene_x3d/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_scene_x3d/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_scene_x3d/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -40,7 +40,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, BoolProperty
 from io_utils import ImportHelper, ExportHelper
 
 

Modified: trunk/py/scripts/addons/io_shape_mdd/__init__.py
===================================================================
--- trunk/py/scripts/addons/io_shape_mdd/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/io_shape_mdd/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -40,7 +40,7 @@
 
 
 import bpy
-from bpy.props import *
+from bpy.props import StringProperty, IntProperty
 from io_utils import ExportHelper, ImportHelper
 
 

Modified: trunk/py/scripts/addons/render_povray/__init__.py
===================================================================
--- trunk/py/scripts/addons/render_povray/__init__.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/render_povray/__init__.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -40,7 +40,7 @@
 
 else:
     import bpy
-    from bpy.props import *
+    from bpy.props import StringProperty, BoolProperty, IntProperty, FloatProperty, FloatVectorProperty, EnumProperty
     from render_povray import ui
     from render_povray import render
 

Modified: trunk/py/scripts/addons/space_view3d_copy_attributes.py
===================================================================
--- trunk/py/scripts/addons/space_view3d_copy_attributes.py	2011-02-27 11:56:43 UTC (rev 1663)
+++ trunk/py/scripts/addons/space_view3d_copy_attributes.py	2011-02-27 15:27:55 UTC (rev 1664)
@@ -34,7 +34,7 @@
 
 import bpy
 import mathutils
-from mathutils import *
+from mathutils import Matrix, Vector
 
 
 def build_exec(loopfunc, func):



More information about the Bf-extensions-cvs mailing list