[Bf-cycles] Build without OpenImageIO

[Guillaume Chéreau]

OK I did it: D3102 to D3104.

On Tue, Mar 13, 2018 at 4:58 AM, Brecht Van Lommel
<brechtvanlommel at pandora.be> wrote:
> You can submit them as three separate patches.
>
> On Mon, Mar 12, 2018 at 2:47 AM, Guillaume Chéreau
> <guillaume.chereau at gmail.com> wrote:
>>
>> How do I submit a branch to developer.blender instead of a patch?  My
>> current changes consist of three patches, should I make one patch
>> submission for each, or concatenate them into a a single patch?
>>
>> On Mon, Mar 12, 2018 at 5:50 AM, Brecht Van Lommel
>> <brechtvanlommel at pandora.be> wrote:
>> > To get code included in the main Cycles repository, please submit it for
>> > code review here:
>> > https://developer.blender.org/differential/diff/create/
>> >
>> > A GitHub URL is not enough, we want to be able to have a record of the
>> > code
>> > review and be able to comment on lines of code on developer.blender.org.
>> >
>> > Thanks,
>> > Brecht.
>> >
>> > On Sun, Mar 11, 2018 at 3:42 PM, Guillaume Chéreau
>> > <guillaume.chereau at gmail.com> wrote:
>> >>
>> >> OK, then here is the link:
>> >> https://github.com/guillaumechereau/cycles/tree/remove_oiio
>> >>
>> >> This is the branch 'remove_oiio' in my cycles github repo. Please
>> >> ignore the master branch, as it's mostly quick hacks I did in order to
>> >> have something working for goxel.
>> >>
>> >> Guillaume
>> >>
>> >> On Sun, Mar 11, 2018 at 9:10 PM, Nathan Letwory <nathan at mcneel.com>
>> >> wrote:
>> >> > The github URL to it should be ok.
>> >> >
>> >> > On 11 Mar 2018 1:01 pm, "Guillaume Chéreau"
>> >> > <guillaume.chereau at gmail.com>
>> >> > wrote:
>> >> >>
>> >> >> I started to work on a proper branch, it's not done yet, but I can
>> >> >> push it online if anybody is interested to have a look.
>> >> >> What would be the easiest way to share a branch for review?
>> >> >>
>> >> >> Regards,
>> >> >> Guillaume
>> >> >>
>> >> >> On Wed, Mar 7, 2018 at 6:05 AM, Brecht Van Lommel
>> >> >> <brechtvanlommel at pandora.be> wrote:
>> >> >> > Using std::string instead of ustring will lead to a lot more
>> >> >> > memory
>> >> >> > allocations, which can be slow but may be ok in practice for the
>> >> >> > way
>> >> >> > Cycles
>> >> >> > uses it.
>> >> >> >
>> >> >> > Feel free to submit a patch on developer.blender.org when you
>> >> >> > think
>> >> >> > the
>> >> >> > code
>> >> >> > is in a good state.
>> >> >> >
>> >> >> > On Tue, Mar 6, 2018 at 4:47 AM, Guillaume Chéreau
>> >> >> > <guillaume.chereau at gmail.com> wrote:
>> >> >> >>
>> >> >> >> I just started a branch of Cycles on github for the goxel
>> >> >> >> version.
>> >> >> >>
>> >> >> >> My first commit allows to use std::string for ustring and a
>> >> >> >> custom
>> >> >> >> implementation of TypeDef:
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> https://github.com/guillaumechereau/cycles/commit/0f286bc4da5536a19640eb4ede640423e317e733
>> >> >> >>
>> >> >> >> Regards,
>> >> >> >> Guillaume
>> >> >> >>
>> >> >> >> On Tue, Mar 6, 2018 at 10:05 AM, Guillaume Chéreau
>> >> >> >> <guillaume.chereau at gmail.com> wrote:
>> >> >> >> > It is actually not difficult to replace oiio ustring with
>> >> >> >> > std::string
>> >> >> >> > in the code, since the api are almost the same, but the
>> >> >> >> > performance
>> >> >> >> > are probably not as good with std::string.
>> >> >> >> >
>> >> >> >> > In util/util_param.h, I can comment out the
>> >> >> >> > OpenImageIO/ustring.h
>> >> >> >> > include and add those lines:
>> >> >> >> >
>> >> >> >> > // ustring implementation based on std::string.
>> >> >> >> > class ustring : public std::string
>> >> >> >> > {
>> >> >> >> > public:
>> >> >> >> >     ustring() {}
>> >> >> >> >     explicit ustring(const char *str) : std::string(str) {}
>> >> >> >> >     ustring (const ustring &str) : ustring(str.c_str()) {}
>> >> >> >> >     ustring (const std::string &str) : ustring(str.c_str()) {}
>> >> >> >> >     const std::string &string() const { return *this; }
>> >> >> >> >     operator int(void) const { return !empty(); }
>> >> >> >> >     const ustring &operator=(const char *str) { *this = str;
>> >> >> >> > return
>> >> >> >> > *this; }
>> >> >> >> > };
>> >> >> >> > typedef std::hash<std::string> ustringHash;
>> >> >> >> >
>> >> >> >> > And the compilation works.
>> >> >> >> >
>> >> >> >> > Similar treatment can be done for typedesc.
>> >> >> >> >
>> >> >> >> >
>> >> >> >> > Regards,
>> >> >> >> > Guillaume
>> >> >> >> >
>> >> >> >> > --
>> >> >> >> > Guillaume
>> >> >> >> > guillaume.chereau at gmail.com
>> >> >> >> > +886 970422910
>> >> >> >>
>> >> >> >>
>> >> >> >>
>> >> >> >> --
>> >> >> >> Guillaume
>> >> >> >> guillaume.chereau at gmail.com
>> >> >> >> +886 970422910
>> >> >> >> _______________________________________________
>> >> >> >> Bf-cycles mailing list
>> >> >> >> Bf-cycles at blender.org
>> >> >> >> https://lists.blender.org/mailman/listinfo/bf-cycles
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > _______________________________________________
>> >> >> > Bf-cycles mailing list
>> >> >> > Bf-cycles at blender.org
>> >> >> > https://lists.blender.org/mailman/listinfo/bf-cycles
>> >> >> >
>> >> >>
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Guillaume
>> >> >> guillaume.chereau at gmail.com
>> >> >> +886 970422910
>> >> >> _______________________________________________
>> >> >> Bf-cycles mailing list
>> >> >> Bf-cycles at blender.org
>> >> >> https://lists.blender.org/mailman/listinfo/bf-cycles
>> >> >
>> >> >
>> >> > _______________________________________________
>> >> > Bf-cycles mailing list
>> >> > Bf-cycles at blender.org
>> >> > https://lists.blender.org/mailman/listinfo/bf-cycles
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Guillaume
>> >> guillaume.chereau at gmail.com
>> >> +886 970422910
>> >> _______________________________________________
>> >> Bf-cycles mailing list
>> >> Bf-cycles at blender.org
>> >> https://lists.blender.org/mailman/listinfo/bf-cycles
>> >
>> >
>> >
>> > _______________________________________________
>> > Bf-cycles mailing list
>> > Bf-cycles at blender.org
>> > https://lists.blender.org/mailman/listinfo/bf-cycles
>> >
>>
>>
>>
>> --
>> Guillaume
>> guillaume.chereau at gmail.com
>> +886 970422910
>> _______________________________________________
>> Bf-cycles mailing list
>> Bf-cycles at blender.org
>> https://lists.blender.org/mailman/listinfo/bf-cycles
>
>
>
> _______________________________________________
> Bf-cycles mailing list
> Bf-cycles at blender.org
> https://lists.blender.org/mailman/listinfo/bf-cycles
>



-- 
Guillaume
guillaume.chereau at gmail.com
+886 970422910