[Bf-cycles] Cycles Shader::has_surface , has_surface_emission, has_surface_transparent flags

[Mohamed Sakr]

Hi Sergey,

after testing, I see colors are matching in the 2 branches, sorry this
was my fault.
but the unsolved question: do these flags do anything? I see they are
not touched anywhere.

cheers,
Mohamed Sakr

On 3/31/16, Mohamed Sakr <3dsakr at gmail.com> wrote:
> Hi Sergey,
>
> my branch is similar to yours, just some different stuff in the
> standalone part "exporter"
> I didn't understand what is grep?
>
> cheers,
> Mohamed Sakr
>
> On 3/31/16, Sergey Sharybin <sergey.vfx at gmail.com> wrote:
>> Hi,
>>
>> I can't tell you what could be wrong in your branch because it's nowhere
>> published and i can't give cleaner answer where the variables are used
>> than
>> grep will do it:
>>
>> grep -wR "has_surface" .
>> grep -wR "has_surface_emission" .
>>
>> and so on.
>>
>>
>> On Thu, Mar 31, 2016 at 5:26 PM, Mohamed Sakr <3dsakr at gmail.com> wrote:
>>
>>> Hi,
>>>
>>> I wonder where are these flags used? Shader::has_surface,
>>> has_surface_emission, ...etc..
>>> the reason to ask:
>>> I checked my branch against Blender, the scene is pretty simple.
>>> 2 cubes which got only emission to surface, first cube is (255 50 0),
>>> second is (153 255 0)
>>>
>>> inside Blender results appear correctly "same chosen color"
>>> inside my branch results appear wrong "for example with increased
>>> emission strength, values go toward 255 255 0 .."
>>>
>>> any idea if these flags are responsible for this? or anything else
>>> that is missing in my Shader?
>>> I debugged input values and they are correct.
>>>
>>> cheers,
>>> Mohamed Sakr
>>> _______________________________________________
>>> Bf-cycles mailing list
>>> Bf-cycles at blender.org
>>> https://lists.blender.org/mailman/listinfo/bf-cycles
>>>
>>
>>
>>
>> --
>> With best regards, Sergey Sharybin
>>
>