[Bf-cycles] LLVM static libs

Brecht Van Lommel brechtvanlommel at pandora.be
Mon Apr 15 18:20:07 CEST 2013


On Mon, Apr 15, 2013 at 4:12 AM, Dan Eicher <dan at trollwerks.org> wrote:
> I didn't actually test it but it looks like your patch will fail if the
> static libs are installed and LLVM_STATIC == OFF since it only looks for the
> dynamic libs if it can't find the static ones.

Ah ok, I though you wanted to detect this automatically somehow but
that indeed isn't very reliable.

> Attached is a patch that adds a WITH_LLVM_STATIC option (defaults to ON so
> as to not break the other systems) and only checks for one of the
> dynamic/static libs so it'll fail if the correct one isn't found. Might also
> be a good idea to do a mark_as_advanced(WITH_LLVM_STATIC) so the win/apple
> folks aren't tempted to mess with it, dunno?

Patch committed now, however I kept the name as LLVM_STATIC instead of
WITH_LLVM_STATIC, as the WITH_ prefix is more for features you turn
on/off.

Brecht.


More information about the Bf-cycles mailing list