[Bf-cycles] Factor input for Add shader

[Gottfried Hofmann]

Hi,

On 10/27/2012 05:44 PM, Brecht Van Lommel wrote:
> Regardless of the energy conservation thing, the way this is
> implemented does not seems logical to me. One parameter that only
> influences one of the input shaders seems strange, I don't see why one
> input should be different than the other. What would be the use case
> here, what kind of node setup would use this? Would this perhaps be
> better solved with a strength input for all BSDF's?

A strength input for both BSDFs would be a lot better. I just borrowed 
the design from the math-node in the compositor set to "Add" where you 
also can influence one input only. Use-case would be any case where 
you'd use the current Add-Node already but want more control (NPR, 
Motion Graphics, Abstract Stuff).

> Also the clamping to 1.0 doesn't make much sense to me, if you're
> going to break energy conservation anyway there's no point trying to
> keep clamped.

you are right, clamping does not make sense here at all.

Cheers,
Gottfried


>
> Brecht.
>
>
> On Fri, Oct 26, 2012 at 10:00 PM, Gottfried Hofmann
> <gottfried at blenderdiplom.com> wrote:
>> Hey there,
>>
>> one thing I was hoping for since the dawn of Cycles is a factor input
>> for the Add-Shader (just like the mix shader has). I think that's way
>> more intuitive than making the shader you want to add darker/brighter if
>> you want to change the strength of the effect.
>>
>> Here is a simple OSL script that creates such an Add-Shader:
>>
>> #include "stdosl.h"
>>
>> shader node_advancedadd_closure(
>> float Fac = 1.0,
>> closure color Closure1 = 0,
>> closure color Closure2 = 0,
>> output closure color Closure = 0)
>> {
>> float t = clamp(Fac, 0.0, 1.0);
>> Closure = Closure1 + t * Closure2;
>> }
>>
>> To avoid breaking things the factor could be set to 1 by default so the
>> Node would normally work just like the current Add-Shader.
>>
>> Cheers,
>> Gottfried
>> _______________________________________________
>> Bf-cycles mailing list
>> Bf-cycles at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-cycles
> _______________________________________________
> Bf-cycles mailing list
> Bf-cycles at blender.org
> http://lists.blender.org/mailman/listinfo/bf-cycles
>