[Bf-cycles] Motion blur related typo?

storm kartochka22 at yandex.ru
Sun Nov 11 03:28:37 CET 2012


I found it by accident, those lines in util_transform looks suspicious,
ia mm not familiar with matrix dicomposition and not sure it right, but
with that patch camera and object MB produce more predictable result.

Index: intern/cycles/util/util_transform.h
===================================================================
--- intern/cycles/util/util_transform.h	(revision 52083)
+++ intern/cycles/util/util_transform.h	(working copy)
@@ -401,7 +401,7 @@
 		t *= 2.0f;
 
 		decomp.x = quat_interpolate(motion->pre.x, motion->mid.x, t);
-		decomp.y.w = (1.0f - t)*motion->pre.y.w + t*motion->mid.y.w;
+		decomp.y = (1.0f - t)*motion->pre.y + t*motion->mid.y;
 		decomp.z = (1.0f - t)*motion->pre.z + t*motion->mid.z;
 		decomp.w = (1.0f - t)*motion->pre.w + t*motion->mid.w;
 	}
@@ -409,7 +409,7 @@
 		t = (t - 0.5f)*2.0f;
 
 		decomp.x = quat_interpolate(motion->mid.x, motion->post.x, t);
-		decomp.y.w = (1.0f - t)*motion->mid.y.w + t*motion->post.y.w;
+		decomp.y = (1.0f - t)*motion->mid.y + t*motion->post.y;
 		decomp.z = (1.0f - t)*motion->mid.z + t*motion->post.z;
 		decomp.w = (1.0f - t)*motion->mid.w + t*motion->post.w;
 	}




More information about the Bf-cycles mailing list