[Bf-cycles] Cycles per BSDF Bump/Normal mapping support

[Agustin Benavidez]

Thank you Thomas, so keeping only the struct declaration in
rna_nodetree_types.h,
the RNA system will ensure save/load the node socket values right?

Regards
Agus

2012/6/5 Thomas Dinges <blender at dingto.org>

> Hi Agus,
> thanks for the patch. One thing that is obsolete in your patch is the
> declaration of intensity, bump and NodeTexBase in DNA / RNA. Sockets
> don't need to be exposed there, this can be removed. In fact you don't
> have to add this Node to DNA at all. :) Only thing which is needed is
> the declaration of the node in rna_nodetree_types.h.
> I attached a new patch to the patch tracker which removes those things. :)
>
> Regards,
> Thomas
>
> Am 05.06.2012 09:01, schrieb Agustin Benavidez:
> > Hi Brecht, I think i just finish this patch (only per BSDF bump
> > mapping), I follow your recommendations so i think is ready for review.
> > how it looks like in the ui:
> > http://www.pasteall.org/pic/show.php?id=32728
> >
> > I uploaded it in the patch tracker:
> >
> http://projects.blender.org/tracker/index.php?func=detail&aid=31716&group_id=9&atid=127
> > <
> http://projects.blender.org/tracker/index.php?func=detail&aid=31716&group_id=9&atid=127
> >
> >
> > What is not included is normal mapping, I postponed it for the next
> > weekend.
> >
> > I also optimized several part of the added code, so i think the very
> > little performance lost in the GPU tests have been
> > reduced considerably. for CPU there is not any noticeable performance
> > impact from my tests.
> >
> > Thank you Brecht
> > Agus,
> --
> Thomas Dinges
> Blender Developer, Artist and Musician
>
> www.dingto.org
>
> _______________________________________________
> Bf-cycles mailing list
> Bf-cycles at blender.org
> http://lists.blender.org/mailman/listinfo/bf-cycles
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.blender.org/pipermail/bf-cycles/attachments/20120605/00b11588/attachment.htm