[Bf-cycles] Cycles per BSDF Bump/Normal mapping support
blender at dingto.org
Tue Jun 5 09:48:11 CEST 2012
thanks for the patch. One thing that is obsolete in your patch is the
declaration of intensity, bump and NodeTexBase in DNA / RNA. Sockets
don't need to be exposed there, this can be removed. In fact you don't
have to add this Node to DNA at all. :) Only thing which is needed is
the declaration of the node in rna_nodetree_types.h.
I attached a new patch to the patch tracker which removes those things. :)
Am 05.06.2012 09:01, schrieb Agustin Benavidez:
> Hi Brecht, I think i just finish this patch (only per BSDF bump
> mapping), I follow your recommendations so i think is ready for review.
> how it looks like in the ui:
> I uploaded it in the patch tracker:
> What is not included is normal mapping, I postponed it for the next
> I also optimized several part of the added code, so i think the very
> little performance lost in the GPU tests have been
> reduced considerably. for CPU there is not any noticeable performance
> impact from my tests.
> Thank you Brecht
Blender Developer, Artist and Musician
More information about the Bf-cycles