[Bf-cycles] Fireflies with Velvet Shader?

[Brecht Van Lommel]

Committed this patch to svn, with some minor tweaks.

Thanks,
Brecht.

On Tue, Nov 8, 2011 at 11:35 PM, David <erwin94 at gmx.net> wrote:
> Hi,
>
> Just as a starting point, the attached patch seems to get rid of the fireflies (at least in my test scene).
>
>
>
>
> On Nov 7, 2011, at 3:22 AM, Brecht Van Lommel wrote:
>
>> The code is in:
>> intern/cycles/kernel/svm/bsdf_ashikhmin_velvet.h
>>
>> Usually this is caused by division by a very small number (or zero).
>> The question is how to solve this properly, which values to clamp, and
>> by how much so that it doesn't aversely affect pixels that are
>> rendering without fireflies.
>>
>> Brecht.
>>
>> On Mon, Nov 7, 2011 at 2:35 AM, Jordan Miller <jrdnmlr at gmail.com> wrote:
>>> great thanks! I'll pull down the code, which file should I look in?
>>>
>>> jordan
>>>
>>>
>>>
>>> On Nov 6, 2011, at 3:43 PM, Brecht Van Lommel
>>> <brechtvanlommel at pandora.be> wrote:
>>>
>>>> It's indeed a bug, the shader needs to be carefully checked still to
>>>> avoid these issues, it's on the bugs list now.
>>>>
>>>> Brecht.
>>>>
>>>> On Sun, Nov 6, 2011 at 9:07 PM, Jordan Miller <jrdnmlr at gmail.com> wrote:
>>>>> hmm... but it only happens with the Velvet shader. Why would there be fireflies on the velvet and nowhere else? Does anyone know of a workaround? This makes it seem more like a bug and less like a "tradeoff".
>>>>>
>>>>> jordan
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Nov 6, 2011, at 2:33 PM, Kel M wrote:
>>>>>
>>>>>> Fireflies are completely normal in Cycles. It's not really a bug, more of a tradeoff with unbiased raytracers.
>>>>>>
>>>>>> On Sun, Nov 6, 2011 at 2:13 PM, Jordan Miller <jrdnmlr at gmail.com> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> I keep getting fireflies with long renders with Velvet Shaders (see attached). Google can't seem to find discussions about this. Any suggestions where in the code or the setup is the problem or how to do a workaround?
>>>>>>
>>>>>> I've tried all other types of materials but velvet works really well here for me so I'm really hoping a solution is out there. Please advise.
>>>>>>
>>>>>> thanks!
>>>>>> Jordan
>>>>>>
>>>>>>
>>>>>>
>>>>>> <FirefliesWithVelvetInCycles_Highlighted.png>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Bf-cycles mailing list
>>>>>> Bf-cycles at blender.org
>>>>>> http://lists.blender.org/mailman/listinfo/bf-cycles
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Bf-cycles mailing list
>>>>>> Bf-cycles at blender.org
>>>>>> http://lists.blender.org/mailman/listinfo/bf-cycles
>>>>>
>>>>> _______________________________________________
>>>>> Bf-cycles mailing list
>>>>> Bf-cycles at blender.org
>>>>> http://lists.blender.org/mailman/listinfo/bf-cycles
>>>>>
>>>> _______________________________________________
>>>> Bf-cycles mailing list
>>>> Bf-cycles at blender.org
>>>> http://lists.blender.org/mailman/listinfo/bf-cycles
>>> _______________________________________________
>>> Bf-cycles mailing list
>>> Bf-cycles at blender.org
>>> http://lists.blender.org/mailman/listinfo/bf-cycles
>>>
>> _______________________________________________
>> Bf-cycles mailing list
>> Bf-cycles at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-cycles
>
>
> _______________________________________________
> Bf-cycles mailing list
> Bf-cycles at blender.org
> http://lists.blender.org/mailman/listinfo/bf-cycles
>
>