[Bf-committers] Why forbid spaces in enum identifiers?

Julian Eisel julian at blender.org
Wed Mar 18 13:14:26 CET 2020


Hi,

what you report was a bug in the commit, fixed with
https://developer.blender.org/rBdd416681fbb0.

The commit was supposed to only affect our internal properties,
because these really must not contain spaces or they may cause errors,
e.g. https://developer.blender.org/rBe37988fa2131f98.
Before committing I checked where this code is called from and it
didn't seem to be called by BPY. Checking again I see that it actually
is indirectly called from there, that got lost in other search
results.
This code is new in 2.83 so no existing release is affected.

Sorry about this.

Cheers,
- Julian -

----------------------------------------------------------------------
Julian Eisel - julian at blender.org - www.blender.org
Software Developer

On Wed, Mar 18, 2020 at 12:03 PM dima glib via Bf-committers
<bf-committers at blender.org> wrote:
>
> Hi,
>
> Finally got around to download a 2.83 Blender, and noticed that some of my
> addons now crash Blender, due to spaces in certain enum identifiers.
>
> What is the practical motivation for making this change?
>
> I honestly don't see any tangible benefits to such a restriction, whereas
> there are very real disadvantages to it -- for example, file names, ID
> block names, keymap names and such cannot be used as enum identifiers now
> (at least, not without a Base64 encoding/decoding step everywhere these
> properties are used).
>
> Also, judging by the commit diff [1], it doesn't even test for other
> non-alphanumeric characters, so this seems kind of pointless anyway :-P
>
> [1]
> https://git.blender.org/gitweb/gitweb.cgi/blender.git/commitdiff/03a4d3c33f824f966675dbb8fe3b4d645dc88f42
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> https://lists.blender.org/mailman/listinfo/bf-committers


More information about the Bf-committers mailing list