[Bf-committers] with_system_glew / gles options on linux.

[Campbell Barton]

Only justification was this is a common package on Linux.
Versioning issue's aren't worth the hassle though, disabled by default.

On Sun, Sep 3, 2017 at 10:17 AM, Brecht Van Lommel
<brechtvanlommel at pandora.be> wrote:
> Correction: I meant that the default should be OFF.
>
> On Fri, Sep 1, 2017 at 8:38 PM, Brecht Van Lommel <
> brechtvanlommel at pandora.be> wrote:
>
>> I also ran into this issue building Blender 2.8 on Ubuntu 16.04.
>> Defaulting to ON seems indeed better to me, Linux distribution packages
>> that want it OFF can still do that.
>>
>> On Thu, Aug 31, 2017 at 3:19 PM, Ray Molenkamp <ray at lazydodo.com> wrote:
>>
>>> Not my regular platform, but I tend to help out the odd user with linux
>>> building errors, and this
>>> one comes up rather frequently
>>>
>>> In our cmakelist.txt we have an exception for linux that sets
>>>
>>> option(WITH_SYSTEM_GLEW "Use GLEW OpenGL wrapper library provided by the
>>> operating system" ON)
>>> option(WITH_SYSTEM_GLES "Use OpenGL ES library provided by the operating
>>> system"           ON)
>>>
>>> compared to all other platforms where it is off.
>>>
>>> I couldn't find a justification for it, but why are these options (unlike
>>> all other
>>> WITH_SYSTEM_* options even on linux ) ON by default? Especially glew
>>> seems to be
>>> problematic, even more so for blender 2.8 where we can't figure out if
>>> it's glew 1 or 2
>>> at compile time so there's a runtime check in the final binary that'll
>>> prevent code
>>> compiled against 1.x from running.
>>>
>>> We ship with a known good copy in our source tree, why not use it by
>>> default?
>>>
>>> --Ray
>>> _______________________________________________
>>> Bf-committers mailing list
>>> Bf-committers at blender.org
>>> https://lists.blender.org/mailman/listinfo/bf-committers
>>>
>>
>>
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> https://lists.blender.org/mailman/listinfo/bf-committers



-- 
- Campbell