[Bf-committers] Misguided maximums on fps, fps_base?

[Bassam Kurdali]

It has now been closed because apparently :
a- there's a more elegant workaround
b- something about it being OK that fps is an int, even though that
wasn't the problem.

I'm sympathetic that there's a lot of bugs in the tracker, and that
some of them might be quite low priority. But this seems like it was a
mistake (to close)

cheers,
Bassam

On Thu, 2017-06-22 at 15:55 -0700, Bassam Kurdali wrote:
> https://developer.blender.org/T51873
> rather than attach I linked as my smaller videos didn't exhibit the
> problem.
> 
> I don't think anything is wrong with ffprobe. It just looks like some
> videos try to use integers for both fps and fps_base (and since 1.001
> is the typical thing it multiplies them both by 1000) I've seen this
> on
> quite a few videos but most are from a client and I cannot share.
> 
> The 120 limit doesn't really make sense on a ratio.
> 
> On Wed, 2017-06-21 at 09:21 +0200, Sergey Sharybin wrote:
> > Hi,
> > 
> > This is definitely something worth investigating. Please make a
> > report and
> > assign to me. If it's possible, attach small videos which ffprobe
> > reports
> > bad framerate for you.
> > 
> > On Jun 21, 2017 05:16, "Bassam Kurdali" <bassam at urchn.org> wrote:
> > 
> > > Hi folks,
> > > While doing some (Python) testing at work I ran into what seems
> > > to
> > > be a
> > > misguided setting of maximum values on scene.render.fps and
> > > scene.render.fps_base
> > > 
> > > As we know:
> > > frame_rate = fps/fps_base
> > > fps is an integer,
> > > fps_base is a float
> > > so for instance, we get:
> > > 29.97 = 30 / 1.001
> > > 
> > > I found that both fps and fps_base have a maximum of 120,
> > > presumably
> > > with the intention of setting a max frame rate of 120. This does
> > > not
> > > actually work as intended, for instance, ffprobe reports on some
> > > videos
> > > values like 30000 and 1001, which should also give a framerate of
> > > 29.97, however in blender we get 1fps because 120 / 120 is 1!
> > > and suppose we enter 30 and .01, then we get a framerate of 3000,
> > > which
> > > is higher than 120.
> > > 
> > > I don't know who is responsible for this part of the code, but if
> > > you
> > > agree this is a bug I'll file it in the tracker.
> > > Cheers
> > > Bassam
> > > _______________________________________________
> > > Bf-committers mailing list
> > > Bf-committers at blender.org
> > > https://lists.blender.org/mailman/listinfo/bf-committers
> > > 
> > 
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > https://lists.blender.org/mailman/listinfo/bf-committers
> 
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> https://lists.blender.org/mailman/listinfo/bf-committers