[Bf-committers] New glLineWidth Policy

Campbell Barton ideasman42 at gmail.com
Fri Feb 19 21:11:54 CET 2016


On Fri, Feb 19, 2016 at 11:02 PM, Dalai Felinto <dfelinto at gmail.com> wrote:
>> Just thinking there might be a way to guarantee initial
> width of 1.0 for addons only.
>
> We could (easily even) set the opengl states back to their "reset"
> values prior to calling the pre/post drawing callbacks.
>
> In fact I think we *should* do this, if we can't guarantee line width 1.0.

Committed https://developer.blender.org/rBb5b156f

Also committed partial fix for https://developer.blender.org/T47454
which is now working roughly the same as 2.76
(which was in fact not quite correct either with mixed nurbs surfaces
and lines - but nobody reported issues with it).

> --
> blendernetwork.org/dalai-felinto
> www.dalaifelinto.com
>
>
> 2016-02-18 22:37 GMT-02:00 Mike Erwin <significant.bit at gmail.com>:
>> Brecht Van Lommel <brechtvanlommel at pandora.be> wrote:
>>
>>> Mike Erwin <significant.bit at gmail.com> wrote:
>>> > For 2.77 what is left to fix? If it's a small set I say fix those and
>>> keep
>>> > the change. (but of course I would say that) It gets us closer to clean
>>> GL
>>> > usage.
>>>
>>> But it also breaks addon backwards compatibility, which I don't think
>>> is intentional for 2.77?
>>>
>>
>> Of course not :)  At this point this is the big unknown, since it's
>> impossible to review all addon code. Addons must go through the Python
>> interface right? Just thinking there might be a way to guarantee initial
>> width of 1.0 for addons only.
>>
>> Up to now there have been multiple fixes based on bug reports from
>>> users. If we rely on just bug reports then there's likely more corner
>>> cases that are still broken. If we keep these commits then I think
>>> someone should go over all GL_LINE drawing and verify that it's
>>> properly setting the line widths.
>>
>>
>> Sign me up for that. A second or third pair of eyes would help too.
>>
>> -- Mike
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers



-- 
- Campbell


More information about the Bf-committers mailing list