[Bf-committers] Fix T45317: Cycles material preview unnecessarily re-rendering

[Francesc Juhe]

Hi,

Thanks!

I tested it and it seems to trigger a refresh even if the custom node is totally unrelated to any material and also it only triggers for custom properties and custom sockets. If the Custom node has a standard socket there is no refresh.
It can be tested running the custom nodes template on the text editor and then creating and editing nodes.


On 22 Jul 2015, at 15:20, Sergey Sharybin <sergey.vfx at gmail.com> wrote:

> Hi,
> 
> I don't think you can trigger refresh of material from the custom node and
> in fact this sounds like an API regression which better to be resolved from
> our side.
> 
> Do have a patch for this [1] but before going ahead want to have feedback
> from our python/rna department.
> 
> [1] http://www.pasteall.org/59763/diff
> 
> On Wed, Jul 22, 2015 at 2:40 PM, Francesc Juhe <fjuhec at gmail.com> wrote:
> 
>> Hello,
>> 
>> The fix
>> https://developer.blender.org/rBb0df19667fa30ad80631da86198710981ca03824
>> seems to break node material preview updates on external renderer like
>> LuxRender or Mitsuba.
>> 
>> Any suggestion on how to trigger a preview update when working with custom
>> nodes?
>> 
>> Thanks,
>> Francesc
>> _______________________________________________
>> Bf-committers mailing list
>> Bf-committers at blender.org
>> http://lists.blender.org/mailman/listinfo/bf-committers
>> 
> 
> 
> 
> -- 
> With best regards, Sergey Sharybin
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers