[Bf-committers] Credits Page
ideasman42 at gmail.com
Sun Sep 21 14:39:04 CEST 2014
Sergey, having the `author` set correct is good of course, but in
practice I think its not going to work well for us under our current
It means before accepting some patch we have to...
- Manually search git log to check if someone under that name committed before
... (which is a bit fuzzy since names aren't exact - umlauts, middle
initials, common names, nicknames vs real names...)
- Ask for the commiter author before committing (where we might
otherwise just commit directly).
If we can get authors to provide this info in some predictable way
(linked from user URL - eg
https://developer.blender.org/p/campbellbarton/ )... then that can
But manually having to look it up every time IMHO isn't practical.
On Sun, Sep 21, 2014 at 6:17 PM, Sergey Sharybin <sergey.vfx at gmail.com> wrote:
> `arc apply --hold D666` then do regular push. This is a good idea to do
> anyway to review things before they go to the master.If author is not
> correct, you can amend the commit `git commit -a --am --author="Proper Guy
> Differencial only contains authorship information if the patch was
> submitted by arc, if you create patch manually this information is parsed
> but not stored anywhere. There's a TODO in phabricator about this, but not
> gonna to happen any time soon. Plus we're allowing to submit patches to
> maniphest tasks, so arc is not a magic answer.
> On Sun, Sep 21, 2014 at 2:12 PM, Antony Riakiotakis <kalast at gmail.com>
>> Is it possible to correct patch application with arcanist to also use the
>> original author? I've been bitten by this before, not acknowledging patch
>> authors properly.
>> If not better make it a rule to also not apply patches through arcanist.
>> On 21 September 2014 10:05, Sergey Sharybin <sergey.vfx at gmail.com> wrote:
>> > Campbell, i'm not sure what's up to phabricator here. If you want to know
>> > some data about old patches i can write an exporter for you. For the new
>> > one using neither maniphest nor differencial is gonna to be accurate --
>> > with all that tendency to commandeer revision the revisions and those
>> > who doesn't use use arc to commit and screws things up, leading to need
>> > abandon the revision instead of marking it as applied, the stats are not
>> > gonna to be accurate.
>> > We do need to use proper authorship of the git commits, that would solve
>> > hell of a lot parsing issues, which currently sounds just weird to have.
>> > Even more -- it's much cooler when the commit is authored by you instead
>> > having just "Path by Awesome Guy".
>> > For this we've got like everything, apart from the email. For this:
>> > - Phabricator considers this a private information and will show it to
>> > nobody.
>> > - You need to ensure someone is OK to provide his email for the commit.
>> > - You only need to do this once, it's very much likely someone sent some
>> > patch in the past.
>> > - You can you use empty email, by explicitly specifying <>: git commit -a
>> > --author "Awesome Guy <>" -m "Patch adds some real awesome things".
>> > - By you i mean the one who applies the patch.
>> > - Personally i'd just make it a rule to sue proper authorship, it's not
>> > difficult than typing "Patch By" anyway.
>> > And again, if some data from the past is needed to be exported, i'd
>> > exporting it once using php script, putting it as a .py dict and use it
>> > the script which traverses the git repo to gather contributors.
>> > On Sun, Sep 21, 2014 at 8:27 AM, Harley Acheson <
>> harley.acheson at gmail.com>
>> > wrote:
>> > > Removing the page seems like an extreme reaction.
>> > >
>> > > Why not just keep the page creation as it is right now but then
>> > > a static html list of the missing 253 names into an "Also Thanks To"
>> > > section until you have this problem sorted out properly?
>> > >
>> > > Cheers, Harley
>> > > _______________________________________________
>> > > Bf-committers mailing list
>> > > Bf-committers at blender.org
>> > > http://lists.blender.org/mailman/listinfo/bf-committers
>> > >
>> > --
>> > With best regards, Sergey Sharybin
>> > _______________________________________________
>> > Bf-committers mailing list
>> > Bf-committers at blender.org
>> > http://lists.blender.org/mailman/listinfo/bf-committers
>> Bf-committers mailing list
>> Bf-committers at blender.org
> With best regards, Sergey Sharybin
> Bf-committers mailing list
> Bf-committers at blender.org
More information about the Bf-committers