[Bf-committers] cloth

[Fredrik hansson]

for the first patch do take a look at openmp for threading instead as it would become more portable and is already used in blender in several places.it also would handle different amounts of cores better. 

// Fredrik

     On Tuesday, September 30, 2014 7:32 PM, Jim Gaston <jim.gaston at gerbertechnology.com> wrote:
   

 Hi All,

I've made a couple of changes to the cloth modifier.
Since I'm new to blender (and open source generally) any advice is
welcome.


**The first patch changes collision.c
The patch make the cloth collision detection multithreaded.

    http://www.pasteall.org/54287/c

I've gotten good results on my system.
Unfortunately It's not portable, so I need some help to make it portable.
I tested it, but I always worry reentrancy.




**The second patch changes implicit.c
The patch forces the seams together after frame 15.

    http://www.pasteall.org/54288/c

Probably this change should be optional (I've hardcoded at the moment)
and instead of using a fixed frame number probably it should use the
pre-roll value instead.

Thank you and Regards
Jim



-----Original Message-----
From: bf-committers-bounces at blender.org
[mailto:bf-committers-bounces at blender.org] On Behalf Of Dan McGrath
Sent: Tuesday, September 30, 2014 1:05 PM
To: bf-blender developers
Subject: Re: [Bf-committers] cloth

Hi Jim,

You could probably try submit a patch to our phabricator (
developer.blender.org), or if you don't want the hassle of creating an
account, you could just use pasteall.org and put a link to the code for
others here to look over and critique. Hope this helps?


Dan

On Mon, Sep 29, 2014 at 11:50 AM, Jim Gaston <
jim.gaston at gerbertechnology.com> wrote:

> Hi Dan,
>        Thank you for the reply.
>
>        I have a couple of patches I have made locally to the cloth
> modifier,
>        But the patches need work.
>
>
>        The first patch is a multithreaded version of
> cloth_bvh_objcollisions_nearcheck().
>        It improves the speed of the cloth simulation.
>        unfortunately, I don't know how to code it *portably*.
>
>        The second patch causes sew lines to close after frame 15.
(Jez's
> sew springs).
>        It works well for my application, but it needs to UI to make it
> optional and set the start frame.
>        And it could be unacceptable because it is applied after the
> collision checks.
>
>
>        both patches are small. Less than 100 lines.
>
> Regards
> Jim
>
>
> -----Original Message-----
> From: bf-committers-bounces at blender.org
> [mailto:bf-committers-bounces at blender.org] On Behalf Of Dan McGrath
> Sent: Monday, September 29, 2014 11:31 AM
> To: bf-blender developers
> Subject: Re: [Bf-committers] cloth
>
> Well, it depends on specifically what you are looking for. This list is
> for
> coders/coding, not for something looking for tutorials/help on how to
use
> cloth simulation.
>
>
> Dan
>
> On Mon, Sep 29, 2014 at 11:06 AM, Jim Gaston <
> jim.gaston at gerbertechnology.com> wrote:
>
> > Hello.
> >
> >
> >
> > I am interested in the blender cloth simulation.
> >
> > Is this the correct mailing list?
> >
> >
> >
> > Thank you and regards
> >
> > Jim
> > _______________________________________________
> > Bf-committers mailing list
> > Bf-committers at blender.org
> > http://lists.blender.org/mailman/listinfo/bf-committers
> >
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
> _______________________________________________
> Bf-committers mailing list
> Bf-committers at blender.org
> http://lists.blender.org/mailman/listinfo/bf-committers
>
_______________________________________________
Bf-committers mailing list
Bf-committers at blender.org
http://lists.blender.org/mailman/listinfo/bf-committers
_______________________________________________
Bf-committers mailing list
Bf-committers at blender.org
http://lists.blender.org/mailman/listinfo/bf-committers