[Bf-committers] [Bf-blender-cvs] [55b2a5a] master: More fixes, msvc 2008 needs math includes for "isnan"..

Sergey Sharybin sergey.vfx at gmail.com
Thu May 1 08:08:35 CEST 2014


C'mon, guys. Are you really serious or it's 1st april and not 1st may today?

Including OWN headers headers based NOT only the platform but also compiler
version is REALLY wrong.

What is the point of this anyway?!


On Thu, May 1, 2014 at 4:36 AM, Thomas Dinges <noreply at git.blender.org>wrote:

> Commit: 55b2a5aa4535a064e4d8eab20a3605f73821caa9
> Author: Thomas Dinges
> Date:   Thu May 1 00:36:02 2014 +0200
> https://developer.blender.org/rB55b2a5aa4535a064e4d8eab20a3605f73821caa9
>
> More fixes, msvc 2008 needs math includes for "isnan"..
>
> ===================================================================
>
> M       source/blender/imbuf/intern/cineon/cineonlib.c
> M       source/blender/imbuf/intern/cineon/dpxlib.c
>
> ===================================================================
>
> diff --git a/source/blender/imbuf/intern/cineon/cineonlib.c
> b/source/blender/imbuf/intern/cineon/cineonlib.c
> index 880df0c..e8cb550 100644
> --- a/source/blender/imbuf/intern/cineon/cineonlib.c
> +++ b/source/blender/imbuf/intern/cineon/cineonlib.c
> @@ -39,6 +39,10 @@
>  #include "BLI_fileops.h"
>  #include "BLI_utildefines.h"
>
> +#if defined(_MSC_VER) && (_MSC_VER <= 1500)
> +#include "BLI_math_base.h"
> +#endif
> +
>  #include "MEM_guardedalloc.h"
>
>  /*
> diff --git a/source/blender/imbuf/intern/cineon/dpxlib.c
> b/source/blender/imbuf/intern/cineon/dpxlib.c
> index 626d05b..84f80fa 100644
> --- a/source/blender/imbuf/intern/cineon/dpxlib.c
> +++ b/source/blender/imbuf/intern/cineon/dpxlib.c
> @@ -39,6 +39,10 @@
>  #include "BLI_fileops.h"
>  #include "BLI_utildefines.h"
>
> +#if defined(_MSC_VER) && (_MSC_VER <= 1500)
> +#include "BLI_math_base.h"
> +#endif
> +
>  #include "MEM_guardedalloc.h"
>
>  /*
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>



-- 
With best regards, Sergey Sharybin


More information about the Bf-committers mailing list