[Bf-committers] [Bf-blender-cvs] [2df2ef5] master: Bump up default size of vertices in Graph Editor to make them easier to see/select

[Daniel Salazar - patazstudio.com]

Hi Joshua, I noticed this change creates quite a large increase in vertical
and horizontal overlap for visualizing keyframes in the Graph Editor. This
might work nice for simple animation but seems detrimental for dense
animation.

Comparison:

http://www.pasteall.org/pic/show.php?id=66265

kind regards

Daniel Salazar
patazstudio.com


On Fri, Jan 17, 2014 at 6:39 AM, Joshua Leung <noreply at git.blender.org>wrote:

> Commit: 2df2ef5801c107ad4010404085523c5cc14fe313
> Author: Joshua Leung
> Date:   Fri Jan 17 15:26:26 2014 +1300
> https://developer.blender.org/rB2df2ef5801c107ad4010404085523c5cc14fe313
>
> Bump up default size of vertices in Graph Editor to make them easier to
> see/select
>
> ===================================================================
>
> M       source/blender/editors/interface/resources.c
>
> ===================================================================
>
> diff --git a/source/blender/editors/interface/resources.c
> b/source/blender/editors/interface/resources.c
> index e54d4b2..2150da8 100644
> --- a/source/blender/editors/interface/resources.c
> +++ b/source/blender/editors/interface/resources.c
> @@ -893,13 +893,13 @@ void ui_theme_init_default(void)
>         rgba_char_args_set(btheme->tipo.vertex,     0, 0, 0, 255);
>         rgba_char_args_set(btheme->tipo.vertex_select, 255, 133, 0, 255);
>         rgba_char_args_set(btheme->tipo.hilite, 0x60, 0xc0, 0x40, 255);
> -       btheme->tipo.vertex_size = 3;
> +       btheme->tipo.vertex_size = 6;
>
>         rgba_char_args_set(btheme->tipo.handle_vertex,      0, 0, 0, 255);
>         rgba_char_args_set(btheme->tipo.handle_vertex_select, 255, 133, 0,
> 255);
>         rgba_char_args_set(btheme->tipo.handle_auto_clamped, 0x99, 0x40,
> 0x30, 255);
>         rgba_char_args_set(btheme->tipo.handle_sel_auto_clamped, 0xf0,
> 0xaf, 0x90, 255);
> -       btheme->tipo.handle_vertex_size = 4;
> +       btheme->tipo.handle_vertex_size = 5;
>
>         rgba_char_args_set(btheme->tipo.ds_channel,      82, 96, 110, 255);
>         rgba_char_args_set(btheme->tipo.ds_subchannel,  124, 137, 150,
> 255);
> @@ -2353,6 +2353,7 @@ void init_userdef_do_versions(void)
>                 U.tw_size = U.tw_size * 5.0f;
>
>                 /* Action Editor (and NLA Editor) - Keyframe Colors */
> +               /* Graph Editor - larger vertex size defaults */
>                 for (btheme = U.themes.first; btheme; btheme =
> btheme->next) {
>                         /* Action Editor ................. */
>                         /* key types */
> @@ -2373,6 +2374,10 @@ void init_userdef_do_versions(void)
>                         /* key border */
>                         rgba_char_args_set(btheme->tnla.keyborder,
>           0,   0,   0, 255);
>                         rgba_char_args_set(btheme->tnla.keyborder_select,
>        0,   0,   0, 255);
> +
> +                       /* Graph Editor ................... */
> +                       btheme->tipo.vertex_size = 6;
> +                       btheme->tipo.handle_vertex_size = 5;
>                 }
>
>                 /* grease pencil - new layer color */
>
> _______________________________________________
> Bf-blender-cvs mailing list
> Bf-blender-cvs at blender.org
> http://lists.blender.org/mailman/listinfo/bf-blender-cvs
>